Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchAlg code with fixed Linter issues #27

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

heyanuja
Copy link

Removed trailing spaces and fixed tabs and spaces issues

@heyanuja
Copy link
Author

heyanuja commented Oct 7, 2024

Reverting changes from my search.js file because i had a lot of recent test failures stemming from changes made to the search API, particularly in handling user, message, and utility methods. I went back to the OG code and tried to fix it but kept getting some errors - specifically, the errors related to unexpected status codes (400 instead of 200), improper error handling, and issues with modifying global objects like navigator in the test environment. I went through them and these modifications introduced inconsistencies and were causing regressions though not sure why. To pass the tests and go back to a stable codebase, I am reverting these changes and returning to the original logic. going to be ensuring the search API handles requests correctly with expected status codes and outputs. Additionally, mocking techniques will be used to handle environment-specific objects like navigator in utility tests. This reversion i think will maintain compatibility with the test framework while ensuring functionality remains intact and everything is passing now so looks good.

@philliparaujo
Copy link

Good descriptions for context! Everything looks good to me

Copy link

@philliparaujo philliparaujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@philliparaujo philliparaujo merged commit e33ee67 into f24 Oct 7, 2024
1 check passed
@heyanuja heyanuja deleted the searchalgfixes branch October 11, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants