Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Answer Dropdown Toggle to Topics #36

Merged
merged 8 commits into from
Oct 11, 2024
Merged

Adding Answer Dropdown Toggle to Topics #36

merged 8 commits into from
Oct 11, 2024

Conversation

katcday
Copy link

@katcday katcday commented Oct 11, 2024

Upon starting this, I realized that I had done the backend for posts which I thought were topics. At this point I redid the entire backend for topics and figured out the frontend.

  • I imported the partial themes into our repo. I then updated them to display an answer post dropdown on the toggle button.
  • I added yaml files for the topics to setup the api requests.
  • I added the backend logic that toggles the topic data.
  • I added the logic that displays a tag on the topic when answered.
  • I added the logic that changes the dropdown from answer to unanswer.
  • I added test cases to ensure that the data field was toggling correctly.

TESTING

  • I used npm test to make sure that all test cases were passing.
  • I triggered the button through the front end to visually verify that the tag was changing.
  • At this time my build stopped working so I can't upload a video but will as soon as possible.
Screen.Recording.2024-10-11.at.1.11.42.AM.mov

This closes:
#resolve #2
#resolve #11
#resolve #5

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11286207955

Details

  • 38 of 43 (88.37%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 82.638%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/topics/create.js 2 3 66.67%
src/privileges/posts.js 3 5 60.0%
src/topics/tools.js 14 16 87.5%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 11285471213: -0.007%
Covered Lines: 22410
Relevant Lines: 25693

💛 - Coveralls

@katcday katcday added the Question Answered Functionality These issues relate to the ability to mark questions as answered/closed. label Oct 11, 2024
@katcday katcday added this to the Sprint 2 milestone Oct 11, 2024
@katcday katcday marked this pull request as ready for review October 11, 2024 04:46
Copy link

@KesterTan KesterTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@katcday katcday merged commit 24f931a into f24 Oct 11, 2024
1 check passed
@katcday katcday changed the title Answer post UI Adding Answer Dropdown Toggle to Topics Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Answered Functionality These issues relate to the ability to mark questions as answered/closed.
Projects
None yet
4 participants