Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition of _diffrn.id? #17

Open
rowlesmr opened this issue Oct 30, 2024 · 1 comment
Open

Definition of _diffrn.id? #17

rowlesmr opened this issue Oct 30, 2024 · 1 comment
Labels
janitorial Very simple fix

Comments

@rowlesmr
Copy link
Collaborator

rowlesmr commented Oct 30, 2024 •
edited
Loading

_diffrn.id is currently defined as

Unique identifier for a diffraction data set collected under particular diffraction conditions.

Wouldn't it be better defined as

Unique identifier for a set of particular diffraction conditions.

?

Especially as we have _pd_diffractogram.id to identify an individual diffractogram.
@rowlesmr rowlesmr mentioned this issue Oct 30, 2024
Open
@jamesrhester
Copy link
Contributor

Correct, perhaps a PR is in order?

@jamesrhester jamesrhester added the janitorial Very simple fix label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
janitorial Very simple fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesrhester @rowlesmr