-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can the content type of _journal_index.id
be changed from "Integer" to "Word"?
#345
Comments
Sometime has passed so I assume it is reasonable to send out a reminder. @publcif , @nautolycus do you foresee any issue with changing the content type of the |
Sorry for delay. I see no problem with the suggested change. If effected, the _description.text should be changed from "Index number identifier of the JOURNAL_INDEX category" to something like "Unique identifier for a journal index entry term" (and of course the enumeration range omitted). I'm also happy if the However, |
@nautolycus, thank you for the information, I have created PR #449 based on your comments.
My guess would be that
From the definitions in DDL1 dictionary, it seems that items from the |
I prefer not to do this at the moment. There are other categories in the "PUBLICATION" category of CIF_CORE that are really rather generic metadata, so the question then arises of whether to move more (or all) of these into a separate dictionary (or dictionaries) not specific to crystallography. One thing I will look at when we review the content of CIF_CORE for Volume G is whether it would be useful to amplify the definitions for the JOURNAL_* categories. Although they were designed with IUCr journals specifically in mind, giving more detailed definitions might in the long term encourage their use by other publishers. |
Closing this issue as the original concern is solved. |
@nautolycus Thank you for the response. A lot of publishers that provide crystal structures in CIF format as supplementary material are already using these data names to related a crystal structures to specific publications (good!) and so does some databases (i.e. the COD). I know that there is also the @jamesrhester Thank you for closing the issue, I had somehow forgotten about it. |
As discussed in issue #316, the content type of arbitrary loop identifiers in DDLm is being changed to
Word
which covers all case-sensitive CIF2 strings without whitespace symbols (e.g.1
,a
,c7A
). In most cases this migration was quite straightforward, however, the definition of the_journal_index.id
item explicitly states that is it an "Index number identifier" and restricts all of the values to positive integers.The
_journal_index.id
data item seems to have only been added in the DDLm version of the CIF_CORE dictionary and should therefore not have any historic usage practices. Are there any objections against changing it to have theWord
content type?Also, note that the
_journal_index_id
alias does not seem to have ever been used before and so this alias could potentially be completely removed.Based on comments left in #341 I assume that @publcif and @nautolycus may have a stake in this.
The text was updated successfully, but these errors were encountered: