Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index into a default list with more than one key value (ie create ENUMERATION_DEFAULTS) #399

Merged
merged 28 commits into from
Jun 27, 2023
Merged

index into a default list with more than one key value (ie create ENUMERATION_DEFAULTS) #399

merged 28 commits into from
Jun 27, 2023

Commits on May 18, 2023

  1. first attempt at new dataitems

    @rowlesmr
    rowlesmr committed May 18, 2023
    Configuration menu
    Copy the full SHA
    51809ae View commit details
    Browse the repository at this point in the history

  2. updated update date date

    @rowlesmr
    rowlesmr committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3486c02 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. added ENUMERATION_DEFAULTS and reverted changes to ENUMERATION_DEFAULT

    @rowlesmr
    rowlesmr committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    13d3125 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. remove drel 

    as per comments from @jamesrhester
    @rowlesmr
    rowlesmr committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    349941c View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. add Inherited to _type.contents

    @rowlesmr
    rowlesmr committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    99ca32f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into default-list-with-multiple-keys

    @rowlesmr
    rowlesmr committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    8ac6f08 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. it applies to _the_ _reference_ dictionary 

    as clarified in COMCIFS#399 (comment)

Co-authored-by: Antanas Vaitkus <[email protected]>
    @rowlesmr @vaitkus
    rowlesmr and vaitkus committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    c9c4146 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. Clarify description of ENUMERATION_DEFAULTS 

    Co-authored-by: Antanas Vaitkus <[email protected]>
    @rowlesmr @vaitkus
    rowlesmr and vaitkus committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    ed53245 View commit details
    Browse the repository at this point in the history

  2. Enhance description of 'Inherited' in _type.contents 

    Co-authored-by: Antanas Vaitkus <[email protected]>
    @rowlesmr @vaitkus
    rowlesmr and vaitkus committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    2844d7e View commit details
    Browse the repository at this point in the history

  3. clarify description of _enumeration_defaults.value 

    Co-authored-by: Antanas Vaitkus <[email protected]>
    @rowlesmr @vaitkus
    rowlesmr and vaitkus committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    e1f0e2c View commit details
    Browse the repository at this point in the history

  4. clarified descriptions re enumerations

    @rowlesmr
    rowlesmr committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    6da739c View commit details
    Browse the repository at this point in the history

  5. Changed _type.container of _enumeration_defaults.index to 'List' 

    It was `Array`: Ordered set of values of the same type.

whereas, a `List`: Ordered set of values. Elements need not be of same contents type.

List fits better. but also begs the question: "How can a `List` dataitem have a `_type.contents` attribute, if not `Inherited`?"
    @rowlesmr
    rowlesmr committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    5ef972e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'default-list-with-multiple-keys' of https://github.com/… 

    …rowlesmr/cif_core into default-list-with-multiple-keys
    @rowlesmr
    rowlesmr committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    c813d4c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. implement wording changes 

    from @vaitkus
    @rowlesmr
    rowlesmr committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    28127e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Merge branch 'master' into default-list-with-multiple-keys

    @vaitkus
    vaitkus committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    ab0d1f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge branch 'master' into default-list-with-multiple-keys

    @vaitkus
    vaitkus committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    c93304c View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Change the container type to 'List'.

    @vaitkus
    vaitkus committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    5a183cd View commit details
    Browse the repository at this point in the history

  2. Correct the category name in the description.

    @vaitkus
    vaitkus committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    d6ed27a View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Deprecate the ENUMERATION_DEFAULT category.

    @vaitkus
    vaitkus committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    21c752d View commit details
    Browse the repository at this point in the history

  2. Set the same update date for all definitions involved in the PR.

    @vaitkus
    vaitkus committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    159a9e5 View commit details
    Browse the repository at this point in the history

  3. Fix attribute order.

    @vaitkus
    vaitkus committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    e87283d View commit details
    Browse the repository at this point in the history

  4. Deprecate the _enumeration.def_index_id attribute.

    @vaitkus
    vaitkus committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    fff4029 View commit details
    Browse the repository at this point in the history

  5. Adapt the ENUMERATION_SOURCE to work with ENUMERATION_DEFAULTS.

    @vaitkus
    vaitkus committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f02091d View commit details
    Browse the repository at this point in the history

  6. Change ddl.dic version to 4.2.0 and update other dictionaries accordi… 

    …ngly.
    @vaitkus
    vaitkus committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    4e4d707 View commit details
    Browse the repository at this point in the history

  7. Fix layout.

    @vaitkus
    vaitkus committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    d173443 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Merge branch 'master' into default-list-with-multiple-keys

    @vaitkus
    vaitkus committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    855adf6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into default-list-with-multiple-keys

    @vaitkus
    vaitkus committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    41509b1 View commit details
    Browse the repository at this point in the history

  3. Accept @rowlesmr correction. 

    Co-authored-by: Matthew Rowles <[email protected]>
    @vaitkus @rowlesmr
    vaitkus and rowlesmr committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    df2de9e View commit details
    Browse the repository at this point in the history