Update definition of _atom_site_moment_Fourier.wave_vector_seq_id #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
vaitkus
deleted the
update-atom-site-moment-Fourier-wave-vector-seq-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
_atom_site_moment_Fourier.wave_vector_seq_iddata item definition to formally link to the_atom_site_Fourier_wave_vector.seq_iddata item as described in the human-readable part of the definition.Note, that it may be necessary to further update this data item since the
_atom_site_Fourier_wave_vector.seq_idmay change when resolving PR COMCIFS/Modulated_Structures#14.Note, that the assigned purpose and source values differ from the default ones, therefore this might conflict with PR #46