dlt-adaptor-udp, dlt-adaptor-stdin: implement get of verbosity level from input #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LocutusOfBorg
commented
Mar 10, 2017
LocutusOfBorg
commented
gunnarx
reviewed
Mar 28, 2017
src/adaptor/dlt-adaptor-stdin.c
Outdated
| break; | ||
| } else | ||
| { | ||
| printf("Wrong verbosity level, setting default to INFO. Accepted values are: FATAL ERROR WARN INFO DEBUG VERBOSE\n"); |
There was a problem hiding this comment.
The default is already INFO. It is not being changed, so instead of "setting default to INFO" this should probably say: "setting to INFO" or "setting to default value (INFO)" or something similar.
gunnarx
suggested changes
Mar 28, 2017
src/adaptor/dlt-adaptor-udp.c
Outdated
| break; | ||
| } else | ||
| { | ||
| printf("Wrong verbosity level, setting default to INFO. Accepted values are: FATAL ERROR WARN INFO DEBUG VERBOSE\n"); |
gunnarx
approved these changes
Mar 28, 2017
|
Sorry, I meant only to comment but clicked the wrong thing. I did not mean to Request Changes, or to Approve because it is the maintainers job to Approve, but I do not know how to remove "Request Changes" so I change it to "Approve" now. Added a minor comment. Otherwise +1 from me |
|
I did the above changes! thanks! let me know if I can merge the two commits together |
…from input, defaulting to INFO when wrong type or none is provided Signed-off-by: Gianfranco Costamagna <[email protected]>
LocutusOfBorg
force-pushed
the
verbosity-level
branch
from
61e24a7
to
4c757c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.