From 94ade20dc45bb3d2914715173e032ce067996da5 Mon Sep 17 00:00:00 2001 From: Liisa Lado-Villar <145-lilado@users.noreply.gitlab.ci.csc.fi> Date: Fri, 26 Jan 2024 16:41:24 +0200 Subject: [PATCH 1/6] refactor eslint configuration to allow camelcase for footerOptions --- swift_browser_ui_frontend/src/components/ShareModalTable.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/swift_browser_ui_frontend/src/components/ShareModalTable.vue b/swift_browser_ui_frontend/src/components/ShareModalTable.vue index 5f0f3c996..9bb729e99 100644 --- a/swift_browser_ui_frontend/src/components/ShareModalTable.vue +++ b/swift_browser_ui_frontend/src/components/ShareModalTable.vue @@ -56,6 +56,7 @@ + Date: Thu, 1 Feb 2024 13:14:44 +0200 Subject: [PATCH 2/6] use i18n-t tags instead of v-html --- swift_browser_ui_frontend/src/components/ShareModal.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/swift_browser_ui_frontend/src/components/ShareModal.vue b/swift_browser_ui_frontend/src/components/ShareModal.vue index 5fabb6519..237249f62 100644 --- a/swift_browser_ui_frontend/src/components/ShareModal.vue +++ b/swift_browser_ui_frontend/src/components/ShareModal.vue @@ -174,6 +174,7 @@ import { addNewTag, deleteTag, } from "@/common/globalFunctions"; + import { addFocusClass, removeFocusClass, From 45bb7b053ac9998073bdd09de351a525fb474b83 Mon Sep 17 00:00:00 2001 From: Liisa Lado-Villar <145-lilado@users.noreply.gitlab.ci.csc.fi> Date: Fri, 2 Feb 2024 11:07:15 +0200 Subject: [PATCH 3/6] fix removing v-html from shareguide list --- swift_browser_ui_frontend/src/components/ShareModal.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/swift_browser_ui_frontend/src/components/ShareModal.vue b/swift_browser_ui_frontend/src/components/ShareModal.vue index 237249f62..5fabb6519 100644 --- a/swift_browser_ui_frontend/src/components/ShareModal.vue +++ b/swift_browser_ui_frontend/src/components/ShareModal.vue @@ -174,7 +174,6 @@ import { addNewTag, deleteTag, } from "@/common/globalFunctions"; - import { addFocusClass, removeFocusClass, From 2498287313e093bb8d962ea88020a0130ab48ad1 Mon Sep 17 00:00:00 2001 From: Liisa Lado-Villar <145-lilado@users.noreply.gitlab.ci.csc.fi> Date: Fri, 23 Feb 2024 16:22:38 +0200 Subject: [PATCH 4/6] replace v-html with v-if v-for --- CHANGELOG.md | 3 +- .../src/components/SearchResultItem.vue | 67 ++++++++++++++----- 2 files changed, 54 insertions(+), 16 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30864bfb1..6a6aafbd0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,7 +29,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - (GL #1180) Add enforcing token lifetimes to signature authentication middleware ### Changed -- Refactor to remove eslint supression +- (GL #1197) Refactor to remove eslint supression + - for search replaced v-html with v-if and v-for - for sharing and sharing tooltip including language changes - for share modal to comply Vue style guide - no-prototype-builtins and camel case diff --git a/swift_browser_ui_frontend/src/components/SearchResultItem.vue b/swift_browser_ui_frontend/src/components/SearchResultItem.vue index df77e32c9..cab9179b9 100644 --- a/swift_browser_ui_frontend/src/components/SearchResultItem.vue +++ b/swift_browser_ui_frontend/src/components/SearchResultItem.vue @@ -13,8 +13,21 @@ ? $t('message.search.container') : $t('message.search.object') }}: - - + + + + {{ apart }} + + {{ apart }} + + + {{ getFilename() }}
@@ -25,14 +38,35 @@ {{ $t('message.search.folder') }}: - - + + + + {{ pathp }} + + {{ pathp }} + + + {{ getFilePath() }}
{{ $t('message.search.tags') }}: - - + + {{ atag }} + {{ atag }} +
@@ -52,9 +86,6 @@