Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestGraph::test_ts_fit_graph failing with xclim v0.45.0 #307

Closed
Zeitsperre opened this issue Sep 15, 2023 · 0 comments · Fixed by #308
Closed

TestGraph::test_ts_fit_graph failing with xclim v0.45.0 #307

Zeitsperre opened this issue Sep 15, 2023 · 0 comments · Fixed by #308
Assignees
Labels
bug Something isn't working

Comments

@Zeitsperre
Copy link
Member

  • RavenPy version: v0.12.2
  • Python version: Any
  • Operating System: All

Description

Tracing the chain of events, it must have something to do with changes to xclim.indicators.generic's fit and stats.

What I Did

 _________________________ TestGraph.test_ts_fit_graph __________________________
[gw0] linux -- Python 3.11.5 /home/runner/work/RavenPy/RavenPy/.tox/py311-linux/bin/python
Traceback (most recent call last):
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/_pytest/runner.py", line 341, in from_call
    result: Optional[TResult] = func()
                                ^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/_pytest/runner.py", line 262, in <lambda>
    lambda: ihook(item=item, **kwds), when=when, reraise=reraise
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_hooks.py", line 493, in __call__
    return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_manager.py", line 115, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_callers.py", line 152, in _multicall
    return outcome.get_result()
           ^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_result.py", line 114, in get_result
    raise exc.with_traceback(exc.__traceback__)
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_callers.py", line 77, in _multicall
    res = hook_impl.function(*args)
          ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/_pytest/runner.py", line 177, in pytest_runtest_call
    raise e
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/_pytest/runner.py", line 169, in pytest_runtest_call
    item.runtest()
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/_pytest/python.py", line 1792, in runtest
    self.ihook.pytest_pyfunc_call(pyfuncitem=self)
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_hooks.py", line 493, in __call__
    return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_manager.py", line 115, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_callers.py", line 113, in _multicall
    raise exception.with_traceback(exception.__traceback__)
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/pluggy/_callers.py", line 77, in _multicall
    res = hook_impl.function(*args)
          ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/_pytest/python.py", line 194, in pytest_pyfunc_call
    result = testfunction(**testargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/tests/test_graphs.py", line 16, in test_ts_fit_graph
    np.testing.assert_array_equal(p.isnull(), False)
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/numpy/testing/_private/utils.py", line 985, in assert_array_equal
    assert_array_compare(operator.__eq__, x, y, err_msg=err_msg,
  File "/opt/hostedtoolcache/Python/3.11.5/x64/lib/python3.11/contextlib.py", line 81, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/RavenPy/RavenPy/.tox/py311-linux/lib/python3.11/site-packages/numpy/testing/_private/utils.py", line 862, in assert_array_compare
    raise AssertionError(msg)
AssertionError: 
Arrays are not equal

Mismatched elements: 2 / 2 (100%)
 x: array([[ True],
       [ True]])
 y: array(False)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants