Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing ROMS-Tools <-> C-Star integration in CI #77

Open
NoraLoose opened this issue Sep 13, 2024 · 2 comments
Open

Testing ROMS-Tools <-> C-Star integration in CI #77

NoraLoose opened this issue Sep 13, 2024 · 2 comments

Comments

@NoraLoose
Copy link
Contributor

We should test the ROMS-Tools integration in the CI. And should ROMS-Tools be a (required or optional) dependency of C-Star as defined in pyproject.toml?

@TomNicholas
Copy link
Contributor

In theory it's optional, at least in the same theoretical sense in which C-Star could support oceananigans.

@dafyddstephenson
Copy link
Contributor

I think for alpha we should treat it as a dependency and make an issue to untangle them. My roms-tools integration PR will include a test (in the old format for now, sorry! I will take some time to study the pytest reformulation once it's in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants