Issues with linting CI

[TomNicholas]

1. I'm not convinced that the formatting linter is running correctly,
2. There is no separate test in the CI for pre-commit

[TomNicholas]

roms-tools looks good, so lets just copy the configuration from there.

[dafyddstephenson]

There is now a separate CI section for pre-commit! (somewhere in the PR line). Also we found out this week roms-tools isn't using mypy, so C-Star linting is stricter.

[dafyddstephenson]

There is now a separate CI section for pre-commit! (somewhere in the PR line).

Strike that, it's already in. In that case I'm not sure I understand the issue.

[TomNicholas]

In #71 (comment) I pulled down your PR branch, which was passing all green in the CI. I immediately ran pre-commit on it locally, and ruff found a bunch of formatting to fix (applied in 9442114). This shouldn't have been possible if everything is working correctly - the PR should have had a red failure. Beyond that I'm not exactly sure what is wrong yet.

[TomNicholas]

There is now a separate CI section for pre-commit! (somewhere in the PR line).

Strike that, it's already in. In that case I'm not sure I understand the issue.

I want it to look more like this, with an explicit extra CI job just for pre-commit (and ideally another one for mypy)

[TomNicholas]

#81 is an example of what I'm talking about - the CI makes it look like tests are failing, when it's actually just a mypy error (much less of a big deal).

[NoraLoose]

That is annoying. Let me issue a quick PR that separates out the pre-commit stuff from the tests.