Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wine-cachyos: Enable LTO compilation for all native libraries #296

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

whrvt
Copy link
Contributor

@whrvt whrvt commented Aug 19, 2024

lto-fixup.patch is a rebase of a patch by Torge Matthies, which supersedes server: Enable link-time optimization by allowing all native modules (i.e. modules compiled without mingw) to be compiled with LTO, not just wineserver.

The relevant compilation flags are added to the PKGBUILD.

@ptr1337
Copy link
Member

ptr1337 commented Aug 19, 2024

This is already included.

nvm: Ive not checked correctly.

@whrvt
Copy link
Contributor Author

whrvt commented Aug 19, 2024

FWIW, it's likely that proton-cachyos can benefit from the same treatment, but I'm not even sure if this was the best place to submit this PR.

@loathingKernel
Copy link
Collaborator

I am positive about using using LTO for everything instead of wineserver only. My issue in the current form is that it modifies the compilation flags in the PKGBUILD. This cannot work for the proton PKGBUILD, it has to be done in Proton's makefile instead. We can keep this open for discussions but we gonna have to apply it independently.

@ptr1337
Copy link
Member

ptr1337 commented Sep 3, 2024

@whrvt Could you maybe rebase? I would like to test this out on the standalone wine-cachyos, before proceeding with the complete proton.

@whrvt
Copy link
Contributor Author

whrvt commented Sep 3, 2024

... proceeding with the complete proton.

I would make a separate PR for Proton.

Copy link
Member

@ptr1337 ptr1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I gonna push this today out and we will see, if any bad reports are coming.

@ptr1337 ptr1337 merged commit 6b885d0 into CachyOS:master Sep 3, 2024
@ptr1337
Copy link
Member

ptr1337 commented Sep 3, 2024

Has been pushed to cachyos-v3, cachyos-v4 and cachyos-znver4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants