systemd-boot-manager: Cleanup series #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vasiliy Stelmachenok <[email protected]>
discard=async is the default for 6.2+ kernels, so there is no need to specify it here. Signed-off-by: Vasiliy Stelmachenok <[email protected]>
This is already automatically managed by systemd and resume hook in initramfs.
I don't see any sense in rootfs that not having a UUID/PARTUUID. It's also normal practice to specify a UUID as root, so make that the default. Signed-off-by: Vasiliy Stelmachenok <[email protected]>
For LUKS2 (which we use by default for systemd-boot installations), it's possible to do without specifying kernel parameters using cryptsetup (https://wiki.archlinux.org/title/Dm-crypt/Specialties#LUKS2) and fstab flags. Also note that TRIM may not be desirable on encrypted partitions and may pose potential security risks. Signed-off-by: Vasiliy Stelmachenok <[email protected]>
Continuous TRIM is not recommended for use on many file systems and can cause problems. Users should use fstrim service and fstrim.timer instead. [1] - https://wiki.archlinux.org/title/Solid_state_drive#TRIM Signed-off-by: Vasiliy Stelmachenok <[email protected]>
Signed-off-by: Vasiliy Stelmachenok <[email protected]>
Signed-off-by: Vasiliy Stelmachenok <[email protected]>
ventureoo
force-pushed
the
systemd-boot-manager-cleanups
branch
from
7263d1c
to
2321c66
Compare
Signed-off-by: Vasiliy Stelmachenok <[email protected]>
Signed-off-by: Vasiliy Stelmachenok <[email protected]>
ventureoo
force-pushed
the
systemd-boot-manager-cleanups
branch
from
2321c66
to
9143388
Compare
|
Tested this so far on my system. No issues found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really need testing.