Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: decorated pots have their side front-faces culled after patch consistent entity vertex ordering #2781

Open
MeeniMc opened this issue Sep 30, 2024 · 1 comment · May be fixed by #2788
Open

Dev: decorated pots have their side front-faces culled after patch consistent entity vertex ordering #2781

MeeniMc opened this issue Sep 30, 2024 · 1 comment · May be fixed by #2788
Labels
S-needs-triage Status: Needs triage

Comments

@MeeniMc
Copy link
Contributor

MeeniMc commented Sep 30, 2024 •
edited
Loading

Bug Description

Decorated pots are missing their side textures, both as inventory items and placed in the world.

image

Original report from Zailer43 on discord https://discord.com/channels/602796788608401408/651120262129123330/1290090607221538899

Suspected related to 3fd78d9

#2745

Reproduction Steps

  • git checkout bade228
  • gradlew runclient:fabric, create a world, etc
  • obtain a decorated pot from the creative inventory

Log File

Log 
[19:25:24] [main/INFO] (FabricLoader/GameProvider) Loading Minecraft 1.21.1 with Fabric Loader 0.16.4
[19:25:24] [main/INFO] (FabricLoader) Loading 11 mods:
        - fabric-api-base 0.4.42+6573ed8c19
        - fabric-block-view-api-v2 1.0.10+6573ed8c19
        - fabric-renderer-api-v1 3.4.0+c705a49c19
        - fabric-rendering-data-attachment-v1 0.3.48+73761d2e19
        - fabric-rendering-fluids-v1 3.1.6+1daea21519
        - fabric-resource-loader-v0 1.3.0+5659912919
        - fabricloader 0.16.4
        - java 21
        - minecraft 1.21.1
        - mixinextras 0.4.1
        - sodium 0.6.0-snapshot+mc1.21.1-local
[19:25:24] [main/INFO] (FabricLoader/Mixin) SpongePowered MIXIN Subsystem Version=0.8.7 Source=file:/C:/Users/Meeni/.gradle/caches/modules-2/files-2.1/net.fabricmc/sponge-mixin/0.15.3+mixin.0.8.7/51ee0a44ab05f6fddd66b09e66b3a16904f9c55d/sponge-mixin-0.15.3+mixin.0.8.7.jar Service=Knot/Fabric Env=CLIENT
[19:25:25] [main/INFO] (FabricLoader/Mixin) Loaded Fabric development mappings for mixin remapper!
[19:25:25] [main/INFO] (FabricLoader/Mixin) Compatibility level set to JAVA_17
[19:25:25] [main/INFO] (FabricLoader/Mixin) Compatibility level set to JAVA_21
[19:25:25] [main/INFO] (Sodium) Loaded configuration file for Sodium: 43 options available, 0 override(s) found
[19:25:25] [main/INFO] (Sodium-GraphicsAdapterProbe) Searching for graphics cards...
[19:25:25] [main/INFO] (Sodium-GraphicsAdapterProbe) Found graphics adapter: AdapterInfo{vendor=AMD, description='AMD Radeon RX 6700 XT', adapterType=0x0000230B, openglIcdFilePath='C:\WINDOWS\System32\DriverStore\FileRepository\u0407010.inf_amd64_3cdbf86c96072d50\B406780\atig6pxx.dll', openglIcdVersion=32.0.11037.4004}
[19:25:27] [Datafixer Bootstrap/INFO] (Minecraft) 226 Datafixer optimizations took 222 milliseconds
[19:25:27] [main/WARN] (PerfmonDisabled) Invalid registry value type detected for PerfOS counters. Should be REG_DWORD. Ignoring: HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\PerfOS\Performance\Disable Performance Counters.
[19:25:27] [main/INFO] (FabricLoader/MixinExtras|Service) Initializing MixinExtras via com.llamalad7.mixinextras.service.MixinExtrasServiceImpl(version=0.4.1).
[19:25:31] [Render thread/INFO] (Minecraft) Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD]
[19:25:31] [Render thread/INFO] (Minecraft) Setting user: Player960
[19:25:31] [Render thread/INFO] (Minecraft) Backend library: LWJGL version 3.3.3-snapshot
[19:25:31] [Render thread/WARN] (FabricLoader/Mixin) Error loading class: net/neoforged/fml/loading/ImmediateWindowHandler (java.lang.ClassNotFoundException: net/neoforged/fml/loading/ImmediateWindowHandler)
[19:25:32] [Render thread/INFO] (Minecraft) OpenGL Vendor: ATI Technologies Inc.
[19:25:32] [Render thread/INFO] (Minecraft) OpenGL Renderer: AMD Radeon RX 6700 XT
[19:25:32] [Render thread/INFO] (Minecraft) OpenGL Version: 3.2.0 Core Profile Context 24.8.1.240822
[19:25:33] [Render thread/INFO] (Minecraft) Reloading ResourceManager: vanilla, fabric, fabric-api-base, fabric-block-view-api-v2, fabric-renderer-api-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-resource-loader-v0, fabricloader, sodium
[19:25:33] [Worker-Main-9/INFO] (Minecraft) Found unifont_all_no_pua-15.1.05.hex, loading
[19:25:33] [Worker-Main-11/INFO] (Minecraft) Found unifont_jp_patch-15.1.05.hex, loading
[19:25:34] [Render thread/WARN] (Minecraft) Missing sound for event: minecraft:item.goat_horn.play
[19:25:34] [Render thread/WARN] (Minecraft) Missing sound for event: minecraft:entity.goat.screaming.horn_break
[19:25:34] [Render thread/INFO] (Minecraft) OpenAL initialized on device OpenAL Soft on 1 - LG TV SSCR2 (AMD High Definition Audio Device)
[19:25:34] [Render thread/INFO] (Minecraft) Sound engine started
[19:25:34] [Render thread/INFO] (Minecraft) Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 512x256x0 minecraft:textures/atlas/particles.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 512x256x0 minecraft:textures/atlas/paintings.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 64x64x0 minecraft:textures/atlas/map_decorations.png-atlas
[19:25:34] [Render thread/INFO] (Minecraft) Created: 1024x512x0 minecraft:textures/atlas/gui.png-atlas
[19:25:34] [Render thread/WARN] (Minecraft) Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program.
[19:26:49] [Render thread/INFO] (Minecraft) Loaded 1290 recipes
[19:26:49] [Render thread/INFO] (Minecraft) Loaded 1399 advancements
[19:26:50] [Server thread/INFO] (Minecraft) Starting integrated minecraft server version 1.21.1
[19:26:50] [Server thread/INFO] (Minecraft) Generating keypair
[19:26:50] [Server thread/INFO] (Minecraft) Preparing start region for dimension minecraft:overworld
[19:26:51] [Render thread/INFO] (Minecraft) Preparing spawn area: 0%
[19:26:51] [Render thread/INFO] (Minecraft) Time elapsed: 342 ms
[19:26:51] [Server thread/INFO] (Minecraft) Changing view distance to 32, from 10
[19:26:51] [Server thread/INFO] (Minecraft) Changing simulation distance to 12, from 0
[19:26:52] [Server thread/INFO] (Minecraft) Player960[local:E:4f3dd8e5] logged in with entity id 80 at (-10.245741139546885, 73.97848098886116, -54.61820976997413)
[19:26:52] [Server thread/INFO] (Minecraft) Player960 joined the game
[19:26:52] [Render thread/INFO] (ChunkBuilder) Started 6 worker threads
[19:26:52] [Render thread/INFO] (Minecraft) Loaded 2 advancements
[19:27:02] [Server thread/INFO] (Minecraft) Saving and pausing game...
[19:27:02] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:overworld
[19:27:02] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_end
[19:27:02] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_nether
[19:27:41] [Render thread/WARN] (Minecraft) Unable to play empty soundEvent: minecraft:entity.cod.ambient
[19:27:42] [Server thread/INFO] (Minecraft) Saving and pausing game...
[19:27:42] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:overworld
[19:27:42] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_end
[19:27:42] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_nether
[19:29:43] [Render thread/INFO] (Minecraft) [System] [CHAT] Saved screenshot as 2024-09-29_19.29.42.png
[19:29:44] [Server thread/INFO] (Minecraft) Saving and pausing game...
[19:29:44] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:overworld
[19:29:44] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_end
[19:29:44] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_nether
[19:33:58] [Server thread/INFO] (Minecraft) Saving and pausing game...
[19:33:58] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:overworld
[19:33:58] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_end
[19:33:58] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_nether
[19:34:01] [Server thread/INFO] (Minecraft) Player960 lost connection: Disconnected
[19:34:01] [Server thread/INFO] (Minecraft) Player960 left the game
[19:34:01] [Server thread/INFO] (Minecraft) Stopping singleplayer server as player logged out
[19:34:01] [Server thread/INFO] (Minecraft) Stopping server
[19:34:01] [Server thread/INFO] (Minecraft) Saving players
[19:34:01] [Server thread/INFO] (Minecraft) Saving worlds
[19:34:02] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:overworld
[19:34:04] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_end
[19:34:04] [Server thread/INFO] (Minecraft) Saving chunks for level 'ServerLevel[issue2266]'/minecraft:the_nether
[19:34:04] [Server thread/INFO] (Minecraft) ThreadedAnvilChunkStorage (issue2266): All chunks are saved
[19:34:04] [Server thread/INFO] (Minecraft) ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[19:34:04] [Server thread/INFO] (Minecraft) ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[19:34:04] [Server thread/INFO] (Minecraft) ThreadedAnvilChunkStorage: All dimensions are saved
[19:34:04] [Render thread/INFO] (ChunkBuilder) Stopping worker threads
[19:34:05] [Render thread/INFO] (Minecraft) Stopping!

Crash Report

Crash report 
---- Minecraft Crash Report ----
// There are four lights!

Time: 2024-09-29 20:12:33
Description: Manually triggered debug crash

java.lang.Throwable: Manually triggered debug crash
        at net.minecraft.client.KeyboardHandler.tick(KeyboardHandler.java:528)
        at net.minecraft.client.Minecraft.tick(Minecraft.java:2009)
        at net.minecraft.client.Minecraft.runTick(Minecraft.java:1246)
        at net.minecraft.client.Minecraft.run(Minecraft.java:882)
        at net.minecraft.client.main.Main.main(Main.java:256)
        at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
        at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
        at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
        at net.fabricmc.devlaunchinjector.Main.main(Main.java:86)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
        at net.minecraft.client.KeyboardHandler.tick(KeyboardHandler.java:528)

-- Manual crash details --
Details:
        Modules:
                ADVAPI32.dll:Advanced Windows 32 Base API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                AUDIOSES.DLL:Audio Session:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                COMCTL32.dll:User Experience Controls Library:6.10 (WinBuild.160101.0800):Microsoft Corporation
                CRYPT32.dll:Crypto API32:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                CRYPTBASE.dll:Base cryptographic API DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                CRYPTSP.dll:Cryptographic Service Provider API:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                CoreMessaging.dll:Microsoft CoreMessaging Dll:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                CoreUIComponents.dll:Microsoft Core UI Components Dll:10.0.22621.3672:Microsoft Corporation
                D3D12Core.dll:Direct3D 12 Core Runtime:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                D3DSCache.dll:Microsoft (R) D3D Shader Caching Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                DBGHELP.DLL:Windows Image Helper:10.0.22621.3593 (WinBuild.160101.0800):Microsoft Corporation
                DEVOBJ.dll:Device Information Set DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation
                DNSAPI.dll:DNS Client API DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                GDI32.dll:GDI Client DLL:10.0.22621.4036 (WinBuild.160101.0800):Microsoft Corporation
                GLU32.dll:OpenGL Utility Library DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                IMM32.DLL:Multi-User Windows IMM32 API Client DLL:10.0.22621.3374 (WinBuild.160101.0800):Microsoft Corporation
                IPHLPAPI.DLL:IP Helper API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                KERNEL32.DLL:Windows NT BASE API Client DLL:10.0.22621.4036 (WinBuild.160101.0800):Microsoft Corporation
                KERNELBASE.dll:Windows NT BASE API Client DLL:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                MMDevApi.dll:MMDevice API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                MSASN1.dll:ASN.1 Runtime APIs:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation
                MSCTF.dll:MSCTF Server DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                MpOav.dll:IOfficeAntiVirus Module:4.18.24080.9 (f49fb7de0d838aeebbdbd940314a35a90705840e):Microsoft Corporation
                NSI.dll:NSI User-mode interface DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                NTASN1.dll:Microsoft ASN.1 API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                OLEAUT32.dll:OLEAUT32.DLL:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                Ole32.dll:Microsoft OLE for Windows:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                OpenAL.dll:Main implementation library:1.23.1:
                POWRPROF.dll:Power Profile Helper DLL:10.0.22621.3374 (WinBuild.160101.0800):Microsoft Corporation
                PSAPI.DLL:Process Status Helper:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                Pdh.dll:Windows Performance Data Helper DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                RPCRT4.dll:Remote Procedure Call Runtime:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation
                SETUPAPI.dll:Windows Setup API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                SHCORE.dll:SHCORE:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                SHELL32.dll:Windows Shell Common Dll:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                UMPDC.dll:User Mode Power Dependency Coordinator:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                USER32.dll:Multi-User Windows USER API Client DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                USERENV.dll:Userenv:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                VCRUNTIME140.dll:Microsoft® C Runtime Library:14.38.33135.0:Microsoft Corporation
                VERSION.dll:Version Checking and File Installation Libraries:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                WINHTTP.dll:Windows HTTP Services:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                WINMM.dll:MCI API DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                WINTRUST.dll:Microsoft Trust Verification APIs:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                WS2_32.dll:Windows Socket 2.0 32-Bit DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                amdihk64.dll:Radeon Settings: Host Service:2,00,00,1788:Advanced Micro Devices, Inc.
                amdxc64.dll:AMD DX12 UMD :8.18.10.0489:Advanced Micro Devices, Inc.
                amsi.dll:Anti-Malware Scan Interface:10.0.22621.3527 (WinBuild.160101.0800):Microsoft Corporation
                apphelp.dll:Application Compatibility Client Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                atig6pxx.dll:atiglpxx.dll:8.14.01.6564:Advanced Micro Devices, Inc.
                atio6axx.dll:AMD OpenGL Driver:24.08.240303_ca9407b:Advanced Micro Devices, Inc
                awt.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                bcrypt.dll:Windows Cryptographic Primitives Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                bcryptPrimitives.dll:Windows Cryptographic Primitives Library:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                cfgmgr32.dll:Configuration Manager DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation
                clbcatq.dll:COM+ Configuration Catalog:2001.12.10941.16384 (WinBuild.160101.0800):Microsoft Corporation
                combase.dll:Microsoft COM for Windows:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                d3d12.dll:Direct3D 12 Runtime:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                dbgcore.DLL:Windows Core Debugging Helpers:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                dcomp.dll:Microsoft DirectComposition Library:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                dinput8.dll:Microsoft DirectInput:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                directxdatabasehelper.dll:DirectXDatabaseHelper:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                dwmapi.dll:Microsoft Desktop Window Manager API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                dxcore.dll:DXCore:10.0.22621.3958 (WinBuild.160101.0800):Microsoft Corporation
                dxgi.dll:DirectX Graphics Infrastructure:10.0.22621.4036 (WinBuild.160101.0800):Microsoft Corporation
                extnet.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                fastprox.dll:WMI Custom Marshaller:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                fwpuclnt.dll:FWP/IPsec User-Mode API:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation
                gdi32full.dll:GDI Client DLL:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                glfw.dll:GLFW 3.4.0 DLL:3.4.0:GLFW
                icm32.dll:Microsoft Color Management Module (CMM):10.0.22621.3880 (WinBuild.160101.0800):Microsoft Corporation
                inputhost.dll:InputHost:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                java.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                java.exe:OpenJDK Platform binary:21.0.4.0:Microsoft
                jemalloc.dll
                jimage.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                jli.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                jna8073577706957041452.dll:JNA native library:7.0.0:Java(TM) Native Access (JNA)
                jsvml.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                jvm.dll:OpenJDK 64-Bit server VM:21.0.4.0:Microsoft
                kernel.appcore.dll:AppModel API Host:10.0.22621.3958 (WinBuild.160101.0800):Microsoft Corporation
                lwjgl.dll
                lwjgl_opengl.dll
                lwjgl_stb.dll
                management.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                management_ext.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                mscms.dll:Microsoft Color Matching System DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                msvcp140.dll:Microsoft® C Runtime Library:14.38.33135.0:Microsoft Corporation
                msvcp_win.dll:Microsoft® C Runtime Library:10.0.22621.3374 (WinBuild.160101.0800):Microsoft Corporation
                msvcrt.dll:Windows NT CRT DLL:7.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation
                mswsock.dll:Microsoft Windows Sockets 2.0 Service Provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                napinsp.dll:E-mail Naming Shim Provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                ncrypt.dll:Windows NCrypt Router:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                net.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                nio.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                nlansp_c.dll:NLA Namespace Service Provider DLL:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                ntdll.dll:NT Layer DLL:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                opengl32.dll:OpenGL Client DLL:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                perfos.dll:Windows System Performance Objects DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                pfclient.dll:SysMain Client:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                pnrpnsp.dll:PNRP Name Space Provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                profapi.dll:User Profile Basic API:10.0.22621.4111 (WinBuild.160101.0800):Microsoft Corporation
                rasadhlp.dll:Remote Access AutoDial Helper:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                resourcepolicyclient.dll:Resource Policy Client:10.0.22621.3527 (WinBuild.160101.0800):Microsoft Corporation
                rsaenh.dll:Microsoft Enhanced Cryptographic Provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                sapi.dll:Speech API:5.3.26906.00 (WinBuild.160101.0800):Microsoft Corporation
                sechost.dll:Host for SCM/SDDL/LSA Lookup APIs:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                shlwapi.dll:Shell Light-weight Utility Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                sunmscapi.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                textinputframework.dll:"TextInputFramework.DYNLINK":10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                twinapi.appcore.dll:twinapi.appcore:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                ucrtbase.dll:Microsoft® C Runtime Library:10.0.22621.3593 (WinBuild.160101.0800):Microsoft Corporation
                uxtheme.dll:Microsoft UxTheme Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                vcruntime140_1.dll:Microsoft® C Runtime Library:14.38.33135.0:Microsoft Corporation
                verify.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
                wbemcomn.dll:WMI:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation
                wbemprox.dll:WMI:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                wbemsvc.dll:WMI:10.0.22621.3672 (WinBuild.160101.0800):Microsoft Corporation
                win32u.dll:Win32u:10.0.22621.4249 (WinBuild.160101.0800):Microsoft Corporation
                windows.storage.dll:Microsoft WinRT Storage API:10.0.22621.3527 (WinBuild.160101.0800):Microsoft Corporation
                winrnr.dll:LDAP RnR Provider DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                wintypes.dll:Windows Base Types DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                wshbth.dll:Windows Sockets Helper DLL:10.0.22621.3958 (WinBuild.160101.0800):Microsoft Corporation
                wshunix.dll:AF_UNIX Winsock2 Helper DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                xinput1_4.dll:Microsoft Common Controller API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation
                zip.dll:OpenJDK Platform binary:21.0.4.0:Microsoft
Stacktrace:
        at net.minecraft.client.KeyboardHandler.tick(KeyboardHandler.java:528)
        at net.minecraft.client.Minecraft.tick(Minecraft.java:2009)
        at net.minecraft.client.Minecraft.runTick(Minecraft.java:1246)
        at net.minecraft.client.Minecraft.run(Minecraft.java:882)
        at net.minecraft.client.main.Main.main(Main.java:256)
        at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
        at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
        at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
        at net.fabricmc.devlaunchinjector.Main.main(Main.java:86)

-- Uptime --
Details:
        JVM uptime: 36.104s
        Wall uptime: 29.056s
        High-res time: 28.431s
        Client ticks: 505 ticks / 25.250s
Stacktrace:
        at net.minecraft.client.Minecraft.fillReport(Minecraft.java:2501)
        at net.minecraft.client.Minecraft.emergencySaveAndCrash(Minecraft.java:949)
        at net.minecraft.client.Minecraft.run(Minecraft.java:902)
        at net.minecraft.client.main.Main.main(Main.java:256)
        at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
        at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
        at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
        at net.fabricmc.devlaunchinjector.Main.main(Main.java:86)

-- Affected level --
Details:
        All players: 1 total; [LocalPlayer['Player67'/83, l='ClientLevel', x=-26.16, y=67.88, z=-50.70]]
        Chunk stats: 5041, 3653
        Level dimension: minecraft:overworld
        Level spawn location: World: (-16,67,-43), Section: (at 0,3,5 in -1,4,-3; chunk contains blocks -16,-64,-48 to -1,319,-33), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1)
        Level time: 5426 game time, 5426 day time
        Server brand: fabric
        Server type: Integrated singleplayer server
        Tracked entity count: 161

-- Last reload --
Details:
        Reload number: 1
        Reload reason: initial
        Finished: Yes
        Packs: vanilla, fabric, fabric-api-base, fabric-block-view-api-v2, fabric-renderer-api-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-resource-loader-v0, fabricloader, sodium

-- System Details --
Details:
        Minecraft Version: 1.21.1
        Minecraft Version ID: 1.21.1
        Operating System: Windows 11 (amd64) version 10.0
        Java Version: 21.0.4, Microsoft
        Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Microsoft
        Memory: 232783872 bytes (222 MiB) / 4276092928 bytes (4078 MiB) up to 4276092928 bytes (4078 MiB)
        CPUs: 12
        Processor Vendor: AuthenticAMD
        Processor Name: AMD Ryzen 5 3600 6-Core Processor
        Identifier: AuthenticAMD Family 23 Model 113 Stepping 0
        Microarchitecture: Zen 2
        Frequency (GHz): 3.60
        Number of physical packages: 1
        Number of physical CPUs: 6
        Number of logical CPUs: 12
        Graphics card #0 name: AMD Radeon RX 6700 XT
        Graphics card #0 vendor: Advanced Micro Devices, Inc.
        Graphics card #0 VRAM (MiB): 12272.00
        Graphics card #0 deviceId: VideoController1
        Graphics card #0 versionInfo: 32.0.11037.4004
        Memory slot #0 capacity (MiB): 8192.00
        Memory slot #0 clockSpeed (GHz): 3.60
        Memory slot #0 type: DDR4
        Memory slot #1 capacity (MiB): 8192.00
        Memory slot #1 clockSpeed (GHz): 3.60
        Memory slot #1 type: DDR4
        Virtual memory max (MiB): 36789.55
        Virtual memory used (MiB): 26987.64
        Swap memory total (MiB): 20480.00
        Swap memory used (MiB): 506.27
        Space in storage for jna.tmpdir (MiB): <path not set>
        Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB): <path not set>
        Space in storage for io.netty.native.workdir (MiB): <path not set>
        Space in storage for java.io.tmpdir (MiB): available: 223092.06, total: 952224.00
        Space in storage for workdir (MiB): available: 130350.69, total: 238472.00
        JVM Flags: 0 total;
        Launched Version: Fabric
        Backend library: LWJGL version 3.3.3-snapshot
        Backend API: AMD Radeon RX 6700 XT GL version 3.2.0 Core Profile Context 24.8.1.240822, ATI Technologies Inc.
        Window size: 3840x2160
        GFLW Platform: win32
        GL Caps: Using framebuffer using OpenGL 3.2
        GL debug messages: 
        Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric'
        Universe: 400921fb54442d18
        Type: Integrated Server (map_client.txt)
        Graphics mode: fancy
        Render Distance: 32/32 chunks
        Resource Packs: vanilla, fabric, fabric-api-base, fabric-block-view-api-v2, fabric-renderer-api-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-resource-loader-v0, fabricloader, sodium
        Current Language: en_us
        Locale: en_US
        System encoding: Cp1252
        File encoding: UTF-8
        CPU: 12x AMD Ryzen 5 3600 6-Core Processor
        Server Running: true
        Player Count: 1 / 8; [ServerPlayer['Player67'/83, l='ServerLevel[issue2266]', x=-26.16, y=67.88, z=-50.70]]
        Active Data Packs: vanilla, fabric
        Available Data Packs: bundle, fabric, trade_rebalance, vanilla
        Enabled Feature Flags: minecraft:vanilla
        World Generation: Stable
        World Seed: 4957284180073197783
@MeeniMc MeeniMc added the S-needs-triage Status: Needs triage label Sep 30, 2024
@MeeniMc
Copy link
Contributor Author

MeeniMc commented Sep 30, 2024 •
edited
Loading

Looking further into this, it appears that the renderDirection is not in the same order as the new order in entityRenderer, which in turn causes the cuboid.shouldDrawFace to return false when it shouldn't, due to the fact that the cuboid.faces is filled up with a bitmask based on the renderDirection ordering.

The renderDirection is obtained from the mixin parameter in cubeMixin so we cannot (should not?) change it.

renderDirections = {RegularEnumSet@25027}  size = 6
 0 = {Direction@25031} "down"
 1 = {Direction@25032} "up"
 2 = {Direction@25033} "north"
 3 = {Direction@25034} "south"
 4 = {Direction@25035} "west"
 5 = {Direction@25036} "east"

@MeeniMc MeeniMc linked a pull request Oct 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-needs-triage Status: Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: some faces of decorated pots would not render MeeniMc/sodium-fabric
1 participant
@MeeniMc