-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method chaining when using update
#100
Comments
This looks super easy to do and would give me an excuse to push v3.3.0. I'm almost done with my 3-month international move so I can't give any firm timelines. I'll either be able to get it done ASAP (I finally have my computer again!) or it might have to wait a bit as there are other major life events in the pipeline. |
As with all things Typescript/Javascript, this is turning out to be a slightly bigger problem than anticipated for unrelated reasons: eslint has been heavily updated since I last used it so my use of the I need to scrub the codebase and try to switch my |
Thank you for updating me! |
I got lazy and squelched the problematic eslint options :) This should be now implemented in 2c60363 |
Amazing! Thank you. Which version will it be released in? |
Btw, may I suggest updating some examples in the readme to include this alternative version? For example: const hash = new jsSHA("SHA-512", "TEXT", { encoding: "UTF8" })
.update("This is a ")
.update("test")
.getHash("HEX"); |
Just released v3.3.0! |
Is your feature request related to a problem? Please describe.
Method chaining can help simplify code.
Describe the solution you'd like
I have a code block like this:
I thought I could simplify it like this:
But it won't be possible since
update
returnsvoid
and notthis
.Perhaps it could return
this
so that chaining becomes possible.The text was updated successfully, but these errors were encountered: