Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure with readline library version 8.1 #228

Open
ellert opened this issue Jan 17, 2021 · 2 comments
Open

Test failure with readline library version 8.1 #228

ellert opened this issue Jan 17, 2021 · 2 comments

Comments

@ellert
Copy link
Contributor

ellert commented Jan 17, 2021

After upgrading the readline library to version 8.1 the following test failure started to appear:

=================================== FAILURES ===================================
_________________________ REPLWrapTestCase.test_python _________________________

self = <metakernel.tests.test_replwrap.REPLWrapTestCase testMethod=test_python>

    def test_python(self):
        if platform.python_implementation() == 'PyPy':
            raise unittest.SkipTest("This test fails on PyPy because of REPL differences")
    
        p = replwrap.python(sys.executable)
        res = p.run_command('4+7')
>       assert res.strip() == '11'
E       AssertionError: assert '\x1b[?2004l\...\n\x1b[?2004h' == '11'
E         - 11
E         + 
E         + 11
E         + 

/builddir/build/BUILD/metakernel-0.27.5/metakernel/tests/test_replwrap.py:81: AssertionError

Downgrading to readline version 8.0 makes the failure go away.

@anewusername
Copy link
Contributor

Per pexpect/pexpect#669 this is unlikely to be fixed upstream, but it is having some impact downstream already ( blink1073/oct2py#237 and blink1073/oct2py#248 ).

Would REPLWrapper.run_command() be a reasonable place to check for and strip any bracketing?

@blink1073
Copy link
Contributor

Would REPLWrapper.run_command() be a reasonable place to check for and strip any bracketing?

Sounds right to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants