We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem description
Within the test suite, TEST_F(cubicSolver_Test, solve_cubic) fails on mingw, as discussed on #1144. For mingw, the check for
TEST_F(cubicSolver_Test, solve_cubic)
mingw
EXPECT_NEAR(nSolnValues, -2, 1.e-6);
fails, where +2 is returned instead. At the moment, the test is disabled (ensuring that the newly introduced mingw GH runner succeeds).
Additional context
The PengRobinson and RedlichKwong models both use this value and do not treat the positive and negative return values equally.
PengRobinson
RedlichKwong
Issue goes back to #1047
An associated test is disabled for mingw:
cantera/test/thermo/cubicSolver_Test.cpp
Lines 26 to 34 in e5122f0
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Problem description
Within the test suite,
TEST_F(cubicSolver_Test, solve_cubic)
fails onmingw
, as discussed on #1144. Formingw
, the check forfails, where +2 is returned instead. At the moment, the test is disabled (ensuring that the newly introduced
mingw
GH runner succeeds).Additional context
Issue goes back to #1047
An associated test is disabled for mingw:
cantera/test/thermo/cubicSolver_Test.cpp
Lines 26 to 34 in e5122f0
The text was updated successfully, but these errors were encountered: