Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempts Submission Column + email, question validation #21

Closed
MathyouMB opened this issue Apr 29, 2021 · 3 comments · Fixed by #35
Closed

Attempts Submission Column + email, question validation #21

MathyouMB opened this issue Apr 29, 2021 · 3 comments · Fixed by #35
Assignees
@ApprenticeofEnder
Labels
code challenge Code Challenge project specific enhancement New feature or request

Comments

@MathyouMB
Copy link
Member

MathyouMB commented Apr 29, 2021 •
edited
Loading

Please add the Attempts column (int) to the Submission model.

Please also add validation to the model that ensures two submissions cannot be created with the same email and question id.

Add a test that validates that the model ensures two submissions cannot be created with the same email and question id.

Screenshot 2021-04-29 at 1 22 17 PM
@MathyouMB MathyouMB added the enhancement New feature or request label Apr 29, 2021
@MathyouMB MathyouMB changed the title Attempts Submission Column + "Has One" email validation Attempts Submission Column + email, question validation Apr 29, 2021
@MathyouMB MathyouMB mentioned this issue Apr 29, 2021
Closed
@MathyouMB MathyouMB added the code challenge Code Challenge project specific label Apr 29, 2021
@MathyouMB
Copy link
Member Author

@ApprenticeofEnder we can pair program on this when you are free to start :)

@ApprenticeofEnder
Copy link
Collaborator

I'm green!

Got a few ideas already.

@ApprenticeofEnder ApprenticeofEnder linked a pull request Apr 30, 2021 that will close this issue
Add attempt counter and uniqueness validation/testing #35
Merged
@ApprenticeofEnder
Copy link
Collaborator

Done and dusted! #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ApprenticeofEnder ApprenticeofEnder

Labels
code challenge Code Challenge project specific enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add attempt counter and uniqueness validation/testing CarletonComputerScienceSociety/core
2 participants
@ApprenticeofEnder @MathyouMB