Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Export AnimatedNumber component #543

Open
davidubuntu opened this issue Nov 30, 2022 · 1 comment
Open

[RFC] Export AnimatedNumber component #543

davidubuntu opened this issue Nov 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@davidubuntu
Copy link

Problem
AnimatedNumber could not be imported from C4R library

Why do we need that
We are developing a comparative Formula Widget specific for a project , whose requirements don't match the current component in C4R
AnimatedNumber component could be reused from the one existing in C4R. In that case we could reuse the component of your code avoiding to repeat code (components, hooks) in our projects.

Screenshot 2022-11-30 at 11 19 22

Proposal
Export AnimatedNumber from C4R so that other projects could use it isolated from FormulaWidget. This component could be really useful for Professional Services.

CC @aaranadev

@davidubuntu davidubuntu added the enhancement New feature or request label Nov 30, 2022
@VictorVelarde
Copy link
Contributor

Hi @davidubuntu,

Thx for the request!.
I'm not against exporting AnimatedNumber if required, but it looks like a quite internal utility, so it would be nice to know why the brand new comparative Formula Widget doesn't fit your use-case. Maybe it's easier to modify current comparative widget or make it more modular (cc/ @moimart)

@josegilg this could be an example of the conversations to have in DS council, to discuss required design vs available widgets and their capabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants