-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Build lipq with SSL support #38
Comments
It's something to consider in the future, but the main issue is that adding an extra dependency (openssl in this case) requires both building the new library, its dependencies and dependants, so at least openssl, libpq, gdal, mapnik and node-mapnik. Otherwise we end up either including multiple versions of a library or adding a dynamic dependency which we don't want in the prebuilts. It's not a priority right now, but we'll keep it in mind the next time we upgrade dependencies. |
OK, clear. Many thanks for your support. |
Your reply got me thinking and realized that my first script only rebuild I've been trying to build Initially I thought it was my changes but finally I made a minimal test that makes it fail too. No change required, just attempt to build using The symptom is 2 missing header files
The full build log is mason-build-mapnink-3.0.15-carto.log The minimal failing case can be found at debug-build.sh I've been running this script as part of a docker container
Would you mind sharing some thoughts and/or directions on how to fix this issue? |
You can see a successful build here: https://travis-ci.org/CartoDB/mason/jobs/556339351 You seem to be missing the include directives for the dependencies downloaded by mason, but I don't know why. |
Hi,
At Akvo we're using Windshaft as one of the components for rendering maps.
When trying to upgrade to a newer version of Windshaft we found the same problem that made us need to compile
node-mapnik
in the past. The librarylibpq
was compiled without SSL support. You can find other people reporting the same problem, e.g. mapnik/mapnik-support#110 and mapnik/mapnik#3656 when trying to reach a SSL enabled PostGIS server.Taking
.travis.yml
as inspiration and just few changes, we managed to compilenode-mapnik
with SSL support.Environment:
The script: build-node-mapnik.sh
And the full build log of running the script in Ubuntu Xenial (docker image
ubuntu:xenial-20190904
) (NOTE: some ANSI scape codes are included and not removed)We would like to propose this change upstream (instead of managing a separate build ourselves)
Is the support for SSL in
libpq
something you would consider? Can we propose this change to this library?Thanks for your support.
The text was updated successfully, but these errors were encountered: