Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update husky hooks #12180

Open
jjspace opened this issue Sep 3, 2024 · 2 comments
Open

Update husky hooks #12180

jjspace opened this issue Sep 3, 2024 · 2 comments
Labels
category - node / npm dependencies Relating to our package dependencies

Comments

@jjspace
Copy link
Contributor

jjspace commented Sep 3, 2024

Got a warning for git commit

husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

I haven't looked into what exactly needs changed or what they're doing in v10 but we should prep for it before the update lands if possible

@jjspace jjspace added category - tooling dependencies Relating to our package dependencies labels Sep 3, 2024
@jjspace jjspace changed the title Update husky hooks Update huksy hooks Sep 3, 2024
@jjspace jjspace changed the title Update huksy hooks Update husky hooks Sep 3, 2024
@lukemckinstry
Copy link
Contributor

I am not seeing this error currently when I run git commit. Do we know of specific conditions to reproduce it @jjspace?

@jjspace
Copy link
Contributor Author

jjspace commented Sep 26, 2024

@lukemckinstry it's not an error, just a warning. If you're not in the CLI your git client may be hiding it. If you're using VSCode you can see it in the git output panel but that panel is very noisy so it's easy to miss it. Also please make sure you're using the latest version of husky, not sure if that matters but I assume it does.

From main:

git checkout -b testing-husky
touch test.js
git add .
git commit -m 'testing'
# see error

# to cleanup
git checkout main
git branch -D testing-husky

2024-09-26_16-42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - node / npm dependencies Relating to our package dependencies
Projects
None yet
Development

No branches or pull requests

3 participants