You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This library depends and imports from libp2p-crypto which hosts multiple crypto libs and utils. Since noise only requires a subset of those, should this library skip the libp2p-crypto middleman and import strictly what's necessary directly @achingbrain ?
This sounds appealing but it would make it much easier to end up with multiple versions of dependencies and/or competing implementations of the same algorithms which would increase bundle sizes when libp2p-* modules are packaged up for the browser, plus you still have it as a transitive dependency through peer-id.
Looking into the code here, libp2p-crypto is only used in non-test code to verify the payload of incoming messages - you could use the pubKey property on the incoming peerId to do the same thing. Then you could make libp2p-crypto a dev dep - eg: #115
This library depends and imports from
libp2p-crypto
which hosts multiple crypto libs and utils. Since noise only requires a subset of those, should this library skip thelibp2p-crypto
middleman and import strictly what's necessary directly @achingbrain ?Related: libp2p/js-libp2p-crypto#215
The text was updated successfully, but these errors were encountered: