fix: use protons instead of protobuf for native .proto to .ts #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaps protobufjs for protons so we can generate `.ts` from `.proto` that is browser friendly (e.g. uses bigints instead of long.js, etc) and isn't broken by default
achingbrain
requested review from
wemeetagain,
mpetrunic,
twoeths and
dapplion
as code owners
|
Interestingly this has the same problem with yarn as #142 but it doesn't fail because aegir is still at % ls -l ./node_modules/.bin/tsc
lrwxr-xr-x 1 alex staff 55 11 Apr 12:00 ./node_modules/.bin/tsc -> ../detective-typescript/node_modules/typescript/bin/tsc |
mpetrunic
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps protobufjs for protons so we can generate
.tsfrom.protothat is browser friendly (e.g. uses bigints instead of long.js, etc) and isn't broken by default.