-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove @libp2p/components #229
fix!: remove @libp2p/components #229
Conversation
`@libp2p/components` is a choke-point for our dependency graph as it depends on every interface, meaning when one interface revs a major `@libp2p/components` major has to change too which means every module depending on it also needs a major. Switch instead to constructor injection of simple objects that let modules declare their dependencies on interfaces directly instead of indirectly via `@libp2p/components` Refs libp2p/js-libp2p-components#6 BREAKING CHANGE: modules no longer implement `Initializable` instead switching to constructor injection
The changes of this PR do not remove The changes of this PR appear to be:
|
It's part of a larger suite of changes to switch to constructor based injection for all libp2p components - see the linked issue in libp2p/js-libp2p-components#6
|
Could this be merged if everyone's happy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @wemeetagain @mpetrunic please review
@libp2p/components
is a choke-point for our dependency graph as it depends on every interface, meaning when one interface revs a major@libp2p/components
major has to change too which means every module depending on it also needs a major.Switch instead to constructor injection of simple objects that let modules declare their dependencies on interfaces directly instead of indirectly via
@libp2p/components
Refs libp2p/js-libp2p-components#6
BREAKING CHANGE: modules no longer implement
Initializable
instead switching to constructor injection