From ea89168f6765371ba6436d3be549fab453304356 Mon Sep 17 00:00:00 2001 From: Navie Chan Date: Tue, 7 May 2024 21:27:58 +0300 Subject: [PATCH] Address my own comment :) --- .../src/chain/opPools/aggregatedAttestationPool.ts | 5 ++--- .../unit/chain/opPools/aggregatedAttestationPool.test.ts | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts b/packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts index 5d794d29637d..d6cceb9572ae 100644 --- a/packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts +++ b/packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts @@ -182,7 +182,7 @@ export class AggregatedAttestationPool { fork: ForkName, forkChoice: IForkChoice, state: CachedBeaconStateAllForks - ): allForks.Attestation[] { + ): phase0.Attestation[] { const stateSlot = state.slot; const stateEpoch = state.epochCtx.epoch; const statePrevEpoch = stateEpoch - 1; @@ -291,7 +291,7 @@ export class AggregatedAttestationPool { fork: ForkName, forkChoice: IForkChoice, state: CachedBeaconStateAllForks - ): allForks.Attestation[] { + ): electra.Attestation[] { const stateSlot = state.slot; const stateEpoch = state.epochCtx.epoch; const statePrevEpoch = stateEpoch - 1; @@ -358,7 +358,6 @@ export class AggregatedAttestationPool { // These properties should not change after being validate in gossip // IF they have to be validated, do it only with one attestation per group since same data // The committeeCountPerSlot can be precomputed once per slot - // for (const [i, {attestation, notSeenAttesterCount}] of attestationGroup for (const [i, attestationNonParticipation] of attestationGroup .getAttestationsForBlock(fork, notSeenAttestingIndices) .entries()) { diff --git a/packages/beacon-node/test/unit/chain/opPools/aggregatedAttestationPool.test.ts b/packages/beacon-node/test/unit/chain/opPools/aggregatedAttestationPool.test.ts index ec570483f689..c375c9956758 100644 --- a/packages/beacon-node/test/unit/chain/opPools/aggregatedAttestationPool.test.ts +++ b/packages/beacon-node/test/unit/chain/opPools/aggregatedAttestationPool.test.ts @@ -382,7 +382,6 @@ describe("aggregateConsolidation", function () { ); const aggAttestation = { ...attestationSeed, - // aggregationBits: BitArray.fromBoolArray(aggregationBitsArr[i]), aggregationBits: new BitArray(new Uint8Array(aggregationBitsArr[i]), 3), committeeBits: commiteeBits, signature: sigArr[i].toBytes(),