Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator CLI #1085

Closed
wemeetagain opened this issue Jul 2, 2020 · 3 comments
Closed

Validator CLI #1085

wemeetagain opened this issue Jul 2, 2020 · 3 comments

Comments

@wemeetagain
Copy link
Member

wemeetagain commented Jul 2, 2020

Is your feature request related to a problem? Please describe.
We need a validator CLI to run validators from the command line.

Describe the solution you'd like
A validator CLI with:

  • ability to run N validators at once
  • the big task here will be handling on-disk persistence, managing keys, user secrets, etc and passing them successfully to the validator nodes
  • safely handle user secrets
  • we likely only need to handle 'keystores', rather than 'walletstores'
  • consistent code style, building off the current beacon command. Eg: Create a validator command, in the same way
  • implementation following community standards and community discussion
    • ideally following closely with other client decisions, picking the best ideas and using them

Describe alternatives you've considered
No CLI? 😭

Additional context
Related to the validator CLI we may need a wallet CLI command. Depending on judgement, that may be completed in parallel or as a prerequisite.

EIP-2335
ethereum/eth2.0-pm#161
See other clients validator clients:
https://github.com/sigp/lighthouse/tree/master/validator_client
https://github.com/PegaSysEng/teku
https://github.com/prysmaticlabs/prysm/
https://github.com/status-im/nimbus
https://github.com/ethereum/trinity/tree/master/eth2

See Eth2 R&D #key-management discord for important discussion on validator key management

@dapplion
Copy link
Contributor

dapplion commented Jul 2, 2020

Do you imagine it being close to ethdo https://github.com/wealdtech/ethdo/blob/master/docs/usage.md ?

@wemeetagain
Copy link
Member Author

wemeetagain commented Jul 2, 2020

I think that would be more related to an account/wallet command, which would manage the on-disk keystores, in a lodestar-opinionated way.

The validator cli command would read on-disk keystores, as configured via cli and on-disk configuration, and use those to init Validators from lodestar-validator.

@wemeetagain
Copy link
Member Author

resolved with #1093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants