Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to not get unwanted subTrees #2408

Closed
dapplion opened this issue Apr 22, 2021 · 2 comments · Fixed by #3760
Closed

Make sure to not get unwanted subTrees #2408

dapplion opened this issue Apr 22, 2021 · 2 comments · Fixed by #3760
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

Even though currently SubTree instances use a WeakRef it would be nice to review our code and ensure that we don't get a SubTree for unwanted items that are likely never gonna change, such as withdrawal credentials or roots.
@dapplion dapplion mentioned this issue Apr 25, 2021
Closed
@dapplion dapplion added the scope-performance Performance issue and ideas to improve performance. label May 1, 2021
@twoeths twoeths mentioned this issue May 20, 2021
Closed
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta-stale Label for stale issues applied by the stale bot. label Jul 8, 2021
@3xtr4t3rr3str14l 3xtr4t3rr3str14l removed the meta-stale Label for stale issues applied by the stale bot. label Jul 8, 2021
@dapplion dapplion added the prio-medium Resolve this some time soon (tm). label Sep 3, 2021
@dapplion dapplion mentioned this issue Nov 29, 2021
Closed
26 tasks
@dapplion dapplion mentioned this issue Apr 26, 2022
Merged
8 tasks
@dapplion
Copy link
Contributor Author

With #3760 any ByteVector and ByteList is represented as a raw Uint8Array without back references

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump SSZ to v0.9.0 ChainSafe/lodestar
2 participants
@3xtr4t3rr3str14l @dapplion