Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossipsub decode performance #2457

Closed
dapplion opened this issue May 1, 2021 · 2 comments
Closed

gossipsub decode performance #2457

dapplion opened this issue May 1, 2021 · 2 comments
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

dapplion commented May 1, 2021

Describe the bug

In Prater our node spends between 10-20% parsing RPC messages. Investigate

  • The file app/node_modules/protons/src/compile/decode.js is really hot
  • It is called from app/node_modules/libp2p-gossipsub/src/index.js:180
    _decodeRpc(bytes) {
        return message_1.RPCCodec.decode(bytes);
    }

Screenshot from 2021-05-01 16-16-29

@dapplion dapplion added the scope-performance Performance issue and ideas to improve performance. label May 1, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta-stale Label for stale issues applied by the stale bot. label Jul 8, 2021
@3xtr4t3rr3str14l 3xtr4t3rr3str14l added the prio-medium Resolve this some time soon (tm). label Jul 8, 2021
@stale stale bot removed the meta-stale Label for stale issues applied by the stale bot. label Jul 8, 2021
@dapplion
Copy link
Contributor Author

Not seen in most recent CPU profiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

No branches or pull requests

2 participants