Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protons performance issue #3000

Closed
dapplion opened this issue Aug 24, 2021 · 1 comment
Closed

protons performance issue #3000

dapplion opened this issue Aug 24, 2021 · 1 comment
Labels
prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

dapplion commented Aug 24, 2021

Describe the bug

protons takes 5% of total CPU time in the main thread, which is really bad.

Screenshot from 2021-08-24 12-32-28

Library protons has been deprecated by the libp2p js team. Latest versions of everything do not include it anymore.

@wemeetagain we must update all libp2p dependencies to get rid of it.

protons is used by

  • libp2p-crypto@^0.18.0
  • libp2p-crypto@^0.19.0
  • libp2p-gossipsub@^0.8.0
  • libp2p-interfaces@^0.8.0, libp2p-interfaces@^0.8.1, libp2p-interfaces@^0.8.3
  • libp2p@^0.30.13
  • peer-id@^0.14.0, peer-id@^0.14.1, peer-id@^0.14.2, peer-id@^0.14.3

Expected behavior

Use efficient protons library Protobufjs

@dapplion dapplion added the scope-performance Performance issue and ideas to improve performance. label Aug 24, 2021
@philknows philknows added the prio-high Resolve issues as soon as possible. label Nov 29, 2021
@dapplion
Copy link
Contributor Author

protons is no longer found in our yarn.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

No branches or pull requests

3 participants