processEth1Data performance issue

[dapplion]

Describe the bug

processEth1Data takes more time than it should (5-6ms, 25% of phase0 block processing times). Looks like iteration takes signficant time + it has to convert the root of each entry from hashObject to Uint8Array and then compare. A bit stupid when it could just use the hashObject numbers

---

From duplicate issue #2453

In Prater our node spends 1400 ms processing Eth1Data. This happens on every block when there's no majority vote.

Same cost every block

detail of the stack

• Add a dedicated performance test
• Optimize

[dapplion]

@wemeetagain noted that the performance test should use a TreeBacked block which makes equality cheaper in our current SSZ implementation. However this function may take a struct or a TreeBacked block. In both cases the code should be fast.

[dapplion]

See #2453 for more detailed CPU profiles

[philknows]

Note to tag this issue with SSZ refactor PR when it's ready.

[dapplion]

• Fixed with Bump SSZ to v0.9.0 #3760