Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate accounts CLI #3300

Closed
dapplion opened this issue Oct 4, 2021 · 1 comment · Fixed by #4104
Closed

Deprecate accounts CLI #3300

dapplion opened this issue Oct 4, 2021 · 1 comment · Fixed by #4104
Labels
prio-low This is nice to have. scope-security Issues that fix security issues: DOS, key leak, CVEs.
Milestone
Audit 2022Q2-batch2

Comments

@dapplion
Copy link
Contributor

dapplion commented Oct 4, 2021

After merging #3296 the accounts CLI is not really necessary anymore. Consider deprecating it or at least removing it from documentation

Lighthouse did already deprecate it and it has been successful among users. Everyone uses Launchpad generated keystores
@dapplion dapplion changed the title Deprecate accounts API Deprecate accounts CLI Oct 4, 2021
@philknows
Copy link
Member

Also some solutions like https://github.com/stake-house/wagyu-key-gen and other interfaces coming online to make it easier to generate keys.

@philknows philknows added the prio-low This is nice to have. label Feb 4, 2022
@dapplion dapplion added the scope-security Issues that fix security issues: DOS, key leak, CVEs. label May 10, 2022
@dapplion dapplion mentioned this issue Jun 3, 2022
Merged
@dapplion dapplion added this to the Audit 2022Q2-batch2 milestone Jun 3, 2022
@philknows philknows mentioned this issue Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-low This is nice to have. scope-security Issues that fix security issues: DOS, key leak, CVEs.
Projects
None yet
Milestone
Audit 2022Q2-batch2
Development

Successfully merging a pull request may close this issue.

Deprecate accounts CLI ChainSafe/lodestar
2 participants
@dapplion @philknows