Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Committee attendance performance issue #3443

Closed
twoeths opened this issue Nov 19, 2021 · 4 comments
Closed

Sync Committee attendance performance issue #3443

twoeths opened this issue Nov 19, 2021 · 4 comments
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@twoeths
Copy link
Contributor

twoeths commented Nov 19, 2021

Describe the bug

In prater, when any validators join sync committee period, the performance is very bad. This maybe related to #3416 where we subscribe to all sync committee subnets with subscribeAllSubnets flag

On Nov 17, some validators joined the sync committee
Screen Shot 2021-11-19 at 10 06 08

More FINDNODES dscv5 query were issues, more dial rate
Screen Shot 2021-11-19 at 10 09 18

At the same time, there are a lot of Goodbye sent/received, a lot of ping/metadata/status request/response too
Screen Shot 2021-11-19 at 10 10 25

Gossip block is delayed a lot
Screen Shot 2021-11-19 at 10 07 07

Expected behavior

No performance issue

@twoeths twoeths added the scope-performance Performance issue and ideas to improve performance. label Nov 19, 2021
@twoeths
Copy link
Contributor Author

twoeths commented Nov 19, 2021

This could also be linked to #2490

When we dial a lot of peers, it's more likely we have to serve beacon_blocks_by_range

Screen Shot 2021-11-19 at 15 37 07

@dapplion
Copy link
Contributor

This could also be linked to #2490

When we dial a lot of peers, it's more likely we have to serve beacon_blocks_by_range

Could be but I'll be surprised it had such an impact on performance, would be worth it to stay vigilant of our nodes and whenever we get selected again to participate in a sync committee take a CPU profile

@twoeths
Copy link
Contributor Author

twoeths commented Nov 19, 2021

vigilant

we can just do a hard code to always subscribe all sync committees and deploy to one of our servers

@dapplion dapplion added the prio-medium Resolve this some time soon (tm). label Feb 4, 2022
@twoeths
Copy link
Contributor Author

twoeths commented Nov 29, 2022

issue is too old, lodestar can publish sync committee messages well with v1.2.1

@twoeths twoeths closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

No branches or pull requests

2 participants