Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerManager: prioritize peers to disconnect #3832

Closed
twoeths opened this issue Mar 6, 2022 · 2 comments
Closed

PeerManager: prioritize peers to disconnect #3832

twoeths opened this issue Mar 6, 2022 · 2 comments
Labels
scope-networking All issues related to networking, gossip, and libp2p.

Comments

@twoeths
Copy link
Contributor

twoeths commented Mar 6, 2022

Is your feature request related to a problem? Please describe.

We need a strategy to prioritize peers to disconnect. At least we need to select peers with least long-lived subnets to disconnect, refer to https://github.com/sigp/lighthouse/blob/1829250ee4df6c4e69687ccdcc69ab79d968e986/beacon_node/lighthouse_network/src/peer_manager/mod.rs#L883

Describe the solution you'd like

  • Work on this TODO:

    // TODO: Priotize peers for disconection better, don't just filter by duty but

  • New metrics to show long-lived subnets of our peers and track it over time to make sure that's an improvement

  • Any changes to the network/peer manager are critical so need to test the work carefully

@philknows
Copy link
Member

Good follow up step to gossipsub resolution.

@philknows philknows added the scope-networking All issues related to networking, gossip, and libp2p. label Mar 22, 2022
@twoeths
Copy link
Contributor Author

twoeths commented May 12, 2022

close via #3955

@twoeths twoeths closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

No branches or pull requests

2 participants