Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use byteArrayEquals instead of ssz.Root.Equals #3996

Closed
dapplion opened this issue May 10, 2022 · 2 comments
Closed

Use byteArrayEquals instead of ssz.Root.Equals #3996

dapplion opened this issue May 10, 2022 · 2 comments
Labels
meta-discussion Indicates a topic that requires input from various developers. prio-low This is nice to have.

Comments

@dapplion
Copy link
Contributor

dapplion commented May 10, 2022 •
edited
Loading

Many codepaths use ssz.Root for things that are not semantically a Root. I feel it would be more clean to just use byteArrayEquals for everything that's always gonna be a Uint8Array. Practically there's not much difference, just a matter of code appearance.

From #3760

What do you think? Marking the issue for discussion
@dapplion dapplion added the meta-discussion Indicates a topic that requires input from various developers. label May 10, 2022
@dapplion dapplion mentioned this issue May 10, 2022
Merged
8 tasks
@wemeetagain
Copy link
Member

Yeah agreed, anything thats not a Root, known to be a Uint8Array, should just use byteArrayEquals.

@dapplion dapplion added the prio-low This is nice to have. label May 18, 2022
@philknows
Copy link
Member

Superseded by #5955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-discussion Indicates a topic that requires input from various developers. prio-low This is nice to have.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wemeetagain @dapplion @philknows