Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize hashing ssz struct values #3997

Closed
dapplion opened this issue May 10, 2022 · 1 comment
Closed

Optimize hashing ssz struct values #3997

dapplion opened this issue May 10, 2022 · 1 comment
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

Tracks ChainSafe/ssz#245

There's a 30% overhead cost converting things back a forth to wasm friendly formats

For context this is only really noticeable when loading states from disk where the full BeaconState has to be hashed. There the saving are in the order of 1s -> 0.7s. However when signing gossip messages the savings are not too significant. Maybe they will be to hash full large ExecutionPayloads.

From #3760
@dapplion dapplion added prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance. labels May 10, 2022
@dapplion dapplion changed the title Optimize hashing of struct values Optimize hashing ssz struct values May 10, 2022
@dapplion dapplion mentioned this issue May 10, 2022
Merged
8 tasks
@philknows
Copy link
Member

Closing. Track optimisation via ChainSafe/ssz#245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dapplion @philknows