New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RootCache #3998

Closed

1 of 2 tasks

dapplion opened this issue May 10, 2022 · 1 comment

Labels

prio-low scope-performance

Contributor

dapplion commented May 10, 2022 •

edited

Loading

RootCache is an optimization that prevent having to walk the tree repeatedly when processing attestations.

After merging #3760 the optimization may not be necessary anymore:

Add performance test with current impl and RootCache Add RootCache performance test #4374
Remove RootCache and ensure performance is as good or better Remove root cache #4375

dapplion added scope-performance prio-low labels

dapplion mentioned this issue

Bump SSZ to v0.9.0 #3760

Merged

8 tasks

This was referenced Aug 6, 2022

Add RootCache performance test #4374

Merged

Remove root cache #4375

Closed

Contributor Author

dapplion commented Aug 13, 2022

After discussing with @tuyennhv RootCache still provides a noticeable performance improvement even with ssz v2, so we are keeping the optimization

dapplion closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment