Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review AggregateAndProof op pool #4028

Closed
twoeths opened this issue May 17, 2022 · 2 comments
Closed

Review AggregateAndProof op pool #4028

twoeths opened this issue May 17, 2022 · 2 comments
Labels
prio-low This is nice to have. scope-profitability Issues to directly improve validator performance and its profitability.

Comments

@twoeths
Copy link
Contributor

twoeths commented May 17, 2022

Describe the bug

The blocks proposed by lodestar usually have 68-74 attestations while blocks adjacent to those slots usually have 128 attestations, need to review if we can do better than that

Expected behavior

  • Make sure no missed attestations due to our AggregateAndProof op pool
  • Call produce_block end point and compare to real data proposed by other clients
@twoeths twoeths mentioned this issue May 17, 2022
Closed
9 tasks
@dapplion
Copy link
Contributor

dapplion commented May 18, 2022 •
edited
Loading

@tuyennhv We could add a new metric to track the balance delta of the proposer whenever we propose. That would track profitability of our blocks and give us data to compare with other clients.

@twoeths twoeths added the prio-low This is nice to have. label May 18, 2022
@philknows philknows added the scope-profitability Issues to directly improve validator performance and its profitability. label May 19, 2022
@dapplion
Copy link
Contributor

Lodestar blocks are fully packed with latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-low This is nice to have. scope-profitability Issues to directly improve validator performance and its profitability.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@twoeths @dapplion @philknows