Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jsonRPC error UX for eth1 + execution #4348

Closed
g11tech opened this issue Jul 27, 2022 · 3 comments · Fixed by #5949
Closed

Improve jsonRPC error UX for eth1 + execution #4348

g11tech opened this issue Jul 27, 2022 · 3 comments · Fixed by #5949
Assignees
Labels
prio-medium Resolve this some time soon (tm). scope-logging Issue about logs: hygiene, format issues, improvements. scope-ux Issues for CLI UX or general consumer UX.

Comments

@g11tech
Copy link
Contributor

g11tech commented Jul 27, 2022

As brought to notice by a discord user seamonkey, sometimes because of the nodejs engine intermittent loading or the execution engine's intermittent loading the json rpc api can throw harmless intermittent errors like UNAVAILABLE, TIMEOUT like these

image

However these give users not so good experience, and hence we need to have an error accumulator for such unavailable errors and log the throw only if counter surpasses.

@g11tech g11tech self-assigned this Jul 27, 2022
@philknows philknows added scope-ux Issues for CLI UX or general consumer UX. prio-medium Resolve this some time soon (tm). labels Aug 12, 2022
@g11tech
Copy link
Contributor Author

g11tech commented Aug 18, 2022

will be picking this up

@dapplion dapplion added the scope-logging Issue about logs: hygiene, format issues, improvements. label May 29, 2023
@nazarhussain nazarhussain self-assigned this Sep 5, 2023
@nazarhussain
Copy link
Contributor

@g11tech We already have a delay set for such cases of errors.

} else if (!isErrorAborted(e)) {
this.logger.error("Error updating eth1 chain cache", {}, e as Error);
await sleep(MIN_WAIT_ON_ERROR_MS, this.signal);
}

And the http errors UNAVAILABLE or TIMEOUT can actually be fatal. We can increase the wait time which is 1s right now, so such errors don't show a lot such errors in case the endpoint if momentarily not available. What do you think?

@g11tech
Copy link
Contributor Author

g11tech commented Sep 7, 2023

@g11tech We already have a delay set for such cases of errors.

} else if (!isErrorAborted(e)) {
this.logger.error("Error updating eth1 chain cache", {}, e as Error);
await sleep(MIN_WAIT_ON_ERROR_MS, this.signal);
}

And the http errors UNAVAILABLE or TIMEOUT can actually be fatal. We can increase the wait time which is 1s right now, so such errors don't show a lot such errors in case the endpoint if momentarily not available. What do you think?

its not about wait time but sort of debounce the error .... like how we do for engine coming offfline online etc. so 1 error for state change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-logging Issue about logs: hygiene, format issues, improvements. scope-ux Issues for CLI UX or general consumer UX.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants