Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass abort signal from top-level to avoid introducing nodejs specific api in downstream components #4513

Closed
dadepo opened this issue Sep 6, 2022 · 1 comment

Comments

@dadepo
Copy link
Contributor

dadepo commented Sep 6, 2022

Shame we have to introduce a nodejs specific api here.

Later we can pass down a signal from the top-level beacon node and avoid creating a new signal here.

Originally posted by @wemeetagain in #4421 (comment)

@dadepo dadepo self-assigned this Sep 6, 2022
@dapplion
Copy link
Contributor

beacon-node leaks more NodeJS specific items. Best to tackle in one go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants