Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable heap memory issue #4896

Closed
twoeths opened this issue Dec 9, 2022 · 3 comments · Fixed by #4901
Closed

Unstable heap memory issue #4896

twoeths opened this issue Dec 9, 2022 · 3 comments · Fixed by #4901

Comments

@twoeths
Copy link
Contributor

twoeths commented Dec 9, 2022

Describe the bug

Memory has been unstable since Dec 06, we need to investigate which PRs caused it

Screen Shot 2022-12-09 at 21 47 04

Expected behavior

Memory should be stable like in v1.2.2

@twoeths
Copy link
Contributor Author

twoeths commented Dec 12, 2022

Have deployed some branches in feat1/beta, it shows that this has happened since we merges #4849

it's also confirmed by regen metrics

Screen Shot 2022-12-12 at 08 46 11

Screen Shot 2022-12-12 at 08 47 06

@twoeths
Copy link
Contributor Author

twoeths commented Dec 12, 2022

in my opinion, for the release of v1.3.0 we should just revert that PR and comment the edge cases that we may need it. In the long term, it will be resolved if we implement the committee cache which is lightweight compared to the current regen strategy. What do you think @dapplion @wemeetagain ?

@dapplion
Copy link
Contributor

dapplion commented Dec 12, 2022

@tuyennhv Ok to me to revert, open an issue and fix properly latter. I would rather wait for a more "proper" solution of regen usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants