Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable unknown block sync after block is synced #5653

Closed
twoeths opened this issue Jun 16, 2023 · 0 comments · Fixed by #5654
Closed

Only enable unknown block sync after block is synced #5653

twoeths opened this issue Jun 16, 2023 · 0 comments · Fixed by #5654
Assignees

Comments

@twoeths
Copy link
Contributor

twoeths commented Jun 16, 2023

Describe the bug

As found in #5650 (comment), when node is syncing it may also receive unknown block root event (especially in a setup with fallback urls), there is no need to search for block at that time

also this is to avoid this case

// the common ancestor of the downloading chain and canonical chain should be at least the finalized slot and

Expected behavior

Only start/init unknown block sync once the node is synced

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.9.0-rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant