-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent style on modals (mobile) #1729
Comments
@serenaho I logged this as I thought we might want to aim for some consistency across all modals but I also may be unaware of other plans in design etc. Do you have any advice on what would be best here? |
In terms of plans, Cindy and I will be auditing all Files components (very soon, ~next week!) in order to build a consistent design system. We will definitely be aiming for consistency across Files, especially with buttons and CTAs like this one. Thank you for bringing it up, I'll put this on my list! |
@serenaho Just need some clarity, what would the preferred appearance be here? :) |
@RyRy79261 Let's use the same Cancel button in the left + middle screens to apply to the right modal for Create Folder. To keep things consistent, I'd also remove the rounded edges from the middle + right modals. Thank you! |
Describe the bug
I noticed that we have a variety of different modal styles in the mobile view. Sometimes we use rounded corners, sometimes flat edges. Sometimes a separate section for the cancel button and sometimes it's within the modal itself
Screenshots
Examples
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: