Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent style on modals (mobile) #1729

Closed
asnaith opened this issue Nov 11, 2021 · 4 comments · Fixed by #1862
Closed

Inconsistent style on modals (mobile) #1729

asnaith opened this issue Nov 11, 2021 · 4 comments · Fixed by #1862
Assignees
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files

Comments

@asnaith
Copy link
Member

asnaith commented Nov 11, 2021

Describe the bug
I noticed that we have a variety of different modal styles in the mobile view. Sometimes we use rounded corners, sometimes flat edges. Sometimes a separate section for the cancel button and sometimes it's within the modal itself

Screenshots

Examples

Screen Shot 2021-11-10 at 4 12 56 PM

Smartphone (please complete the following information):

  • Device: iPhone 12 Mini
  • OS: iOS 15
  • Browser Safari
@asnaith asnaith added Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files labels Nov 11, 2021
@asnaith
Copy link
Member Author

asnaith commented Nov 11, 2021

@serenaho I logged this as I thought we might want to aim for some consistency across all modals but I also may be unaware of other plans in design etc. Do you have any advice on what would be best here?

@serenaho
Copy link
Collaborator

In terms of plans, Cindy and I will be auditing all Files components (very soon, ~next week!) in order to build a consistent design system. We will definitely be aiming for consistency across Files, especially with buttons and CTAs like this one. Thank you for bringing it up, I'll put this on my list!

@RyRy79261
Copy link
Contributor

@serenaho Just need some clarity, what would the preferred appearance be here? :)

@serenaho
Copy link
Collaborator

serenaho commented Nov 12, 2021

Screen Shot 2021-11-10 at 4 12 56 PM

@RyRy79261 Let's use the same Cancel button in the left + middle screens to apply to the right modal for Create Folder.

To keep things consistent, I'd also remove the rounded edges from the middle + right modals. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants