Fix promise in accounts.signTransaction() throwing errors that cannot be caught

[andreistefanwork]

Description

Accounts.signTransaction() can generate a stray Promise under JS job queue, and there's no way for library users to catch any exceptions the stray promise throws, which can kill the entire Node.js process.

Fixes (#4724)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run dtslint with success and extended the tests and types if necessary.
• I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
• I ran npm run build with success.
• I have tested the built dist/web3.min.js in a browser.
• I have tested my code on the live network.
• I have checked the Deploy Preview and it looks correct.
• I have updated the CHANGELOG.md file in the root folder.

[kai-alpha]

Unfortunately I'm not skilled in JS (esp. in raw Promises) enough to review your PR, but it's great you could write a unit test covering this case.

[andreistefanwork]

Hi @jdevcs! Can you guys review the PR and let me know if everything is alright?

[coveralls]

Pull Request Test Coverage Report for Build 2629557193

• 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
• 287 unchanged lines in 8 files lost coverage.
• Overall coverage increased (+2.4%) to 74.388%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/web3-eth-accounts/src/index.js	0	1	0.0%

Files with Coverage Reduction	New Missed Lines	%
packages/web3-core-requestmanager/src/jsonrpc.js	1	70.0%
packages/web3-core-helpers/src/formatters.js	8	84.3%
packages/web3-eth-accounts/lib/index.js	20	85.46%
packages/web3-core-helpers/src/errors.js	29	1.56%
packages/web3-utils/src/soliditySha3.js	34	3.43%
packages/web3-utils/src/index.js	43	31.38%
packages/web3-utils/src/utils.js	45	10.67%
packages/web3-eth-accounts/src/index.js	107	23.67%

Totals
Change from base Build 2616214688:	2.4%
Covered Lines:	3265
Relevant Lines:	4139

---

💛 - Coveralls

[avkos]

Thanks for the fix. but need to check why tests fails

[andreistefanwork]

Hi @avkos! Looking at the failed test, the promise: https://github.com/ChainSafe/web3.js/blob/9d5ce480d8f127e6868605fe684f9707a765e72b/test/e2e.contract.deploy.js#L112-L114

takes more that 2 seconds to resolve during e2e testing with Firefox browser. However, the same test using Chrome browser passes...

Also, this other very similar promise:
https://github.com/ChainSafe/web3.js/blob/9d5ce480d8f127e6868605fe684f9707a765e72b/test/e2e.contract.deploy.js#L97-L99

resolves both on Chrome and on Firefox..

I'm wondering, if we restart the tests, will it pass the second time? I'm really struggling to find a connection between the changes on the PR and the test that fails, without success

[kai-alpha]

Maybe you can rebase onto the latest HEAD and force-push to rerun the tests?

[andreistefanwork]

Ok, so the second run was successful

[jdevcs]

@andreistefanwork This branch has conflicts that must be resolved

[andreistefanwork]

@jdevcs yes, some changelog.md conflicts. Solved them

[andreistefanwork]

@jdevcs @nazarhussain Can this PR be merged & closed?

[jdevcs]

Merged via #5252