Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

flavor builder on minicss.org is broken #140

Open
vpribish opened this issue Jul 18, 2018 · 11 comments · May be fixed by #174
Open

flavor builder on minicss.org is broken #140

vpribish opened this issue Jul 18, 2018 · 11 comments · May be fixed by #174
Labels
bug flavor Gluon help wanted Javascript

Comments

@vpribish
Copy link
Contributor

https://minicss.org/flavors

I changed the base root font size to 12 and hit the "Generate Flavor" button. The zip file downloaded, but the mini-custom.css and mini-custom-min.css files were zero-length. the other files looked ok.

screen shot 2018-07-18 at 4 47 57 pm
@Chalarangelo
Copy link
Owner

I will check that soon and report back with my results.

@Chalarangelo
Copy link
Owner

There's something wrong with the compiler, I suppose. Haven't figured it out just yet, but you can easily compile the mini-custom.scss file yourself (use node-sass to do so) and it will output the CSS files you can use. Sorry for the inconvenience, this is most definitely something I need to fix.

@Chalarangelo
Copy link
Owner

Chalarangelo commented Aug 4, 2018 •
edited
Loading

This is probably an issue with sass.js, I'm currently working on fixing this.

Btw if I host the project locally, it works just fine, so this is a quick workaround for the time being, until I manage to fix this.

@Chalarangelo
Copy link
Owner

Update: I haven't figured tihs out yet, if anyone has any ideas, please submit a PR to resolve this!

@Janee
Copy link

Janee commented Jan 10, 2019

Hello @Chalarangelo
I really love your project, congrats! ❤️
However, I want to try the flavor builder, can you please share me the instructions to run it locally?

Regards

@Chalarangelo
Copy link
Owner

@Janee Clone or download the repo, then serve the docs folder locally (using something like Web Server for Chrome). I think you can just double click the HTML file of that page after downloading as well and it might work fine, too.

@ctholho
Copy link

ctholho commented Feb 4, 2019

I am totally not qualified to say anything at all about this because I don't know SASS or anything relevant. I was just hoping to easily circumvent the whole css stuff thingy with my flask app. But: when I was downloading a custom mini.css all partial scss files in /mini where in fact html files with a 404 error.

<title>Page not found · GitHub Pages</title>.

The mini-custom.css and mini-custom-min.css files were also zero-length and trying to compile this with the python binding of libsass would raise

sass.CompileError: Error: Invalid CSS after "<": expected 1 selector or at-rule, was "<!DOCTYPE html>"

I fear I make a fool out of myself to point this out. But anyhow. Would really love to see this fixed.

@Chalarangelo
Copy link
Owner

Chalarangelo commented Feb 4, 2019 •
edited
Loading

I haven't managed to figure this out, but I'd love some help if anyone is willing to lend a hand. I fear this might be a hosting issue with GitHub pages, as the exact same code works fine onany local environment I've tried it. Maybe it's time to migrate to Netlify after all. I'll check that option, see if it yields any better results. Sorry for taking this long to fix s seemingly straightforward issue and thanks to everyone for all the feedback.

@SirFaenor
Copy link

I am not qualified with Sass so this message could be totally useless, but could it be a simple error in filepaths submitted to sass compiler (resulting in the Github Pages 404 error page being "embedded" in sources files) ? Again, sorry if this suggestion turns out to be useless and congrats for this great project.

@sigmasoldi3r
Copy link

sigmasoldi3r commented Jan 21, 2020 •
edited
Loading

I found that mini/_core.scss is in fact an HTML with a 404 error response, so the file is missing or the server is not responding properly when generating that file, that's why does not compile.
So @SirFaenor is pointing in the right direction.

Edit

Now I see that all the .scss files under /mini folder are the 404 github error page.

Also thanks for this great library! ^^

@sigmasoldi3r sigmasoldi3r linked a pull request Jan 21, 2020 that will close this issue
Open
@sigmasoldi3r
Copy link

Hello again! Seems that #174 should fix the problem!
Github pages ignores files that begin with underscore, so the scss files were not being published.

https://sigmasoldi3r.github.io/mini.css/flavors

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug flavor Gluon help wanted Javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added .nojekyll file to the docs folder sigmasoldi3r/mini.css
6 participants
@Janee @vpribish @Chalarangelo @SirFaenor @sigmasoldi3r @ctholho