Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short multiline chat messages are ignored by SD #12803

Open
CoconutMacaroon opened this issue Aug 22, 2024 · 0 comments · May be fixed by #13797
Open

Short multiline chat messages are ignored by SD #12803

CoconutMacaroon opened this issue Aug 22, 2024 · 0 comments · May be fixed by #13797
Assignees
Labels
area: chat system status: confirmed Confirmed as something that needs working on. type: bug Aaaah! Kill it!

Comments

@CoconutMacaroon
Copy link
Contributor

CoconutMacaroon commented Aug 22, 2024

What problem has occurred?

If you send a short multiline chat command to SD (such as !!/location with some text on a new line), it gets ignored if it would fit in a normal single line message. This came up in the context of a different issue also about multiline messages, and it would be helpful to know if this should be fixed alongside/before that or if this can be considered "won't fix"/"deferred".

I suspect enabling support itself wouldn't be hard, but I don't know is what the side effects of doing so would be.

My theory is here. Cody Gray helped figure this out. However, I haven't validated that theory with a debugger, so it may be wrong.

See also #12732

What would you like to happen/not happen?

A decision is made on whether this should be fixed and these commands are processed (knowing this may cause more bugs) or this is considered something that won't be fixed and I'll remove it as a blocker on the issue/PR with multiline messages.

I don't really have a preference.

@CoconutMacaroon CoconutMacaroon self-assigned this Aug 22, 2024
@codygray codygray added type: bug Aaaah! Kill it! status: confirmed Confirmed as something that needs working on. labels Sep 7, 2024
@CoconutMacaroon CoconutMacaroon linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: chat system status: confirmed Confirmed as something that needs working on. type: bug Aaaah! Kill it!
Development

Successfully merging a pull request may close this issue.

2 participants