Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlitchCon emotes should be grouped into one single group #2341

Closed
Trung0246 opened this issue Jan 6, 2021 · 3 comments · Fixed by #5239
Closed

GlitchCon emotes should be grouped into one single group #2341

Trung0246 opened this issue Jan 6, 2021 · 3 comments · Fixed by #5239

Comments

@Trung0246
Copy link

Trung0246 commented Jan 6, 2021

Currently emotes earned through GlitchCon (2.2.2-fix) are being displayed like this (as if they are separate groups):

image

Is it possible to group them into a single group like those holiday emotes and lgbt+ emotes?

@leon-richardt
Copy link
Collaborator

The grouping is determined by relying on the emote set information provided by Twitch. Although it seems reasonable that the GlitchCon emotes should be in the same emote set, this doesn't seem to be the case.
In order to group them anyway, we would need to manually override the emote set value for specific emotes.

@zneix
Copy link
Collaborator

zneix commented Jan 6, 2021

as if they are separate groups

well... they are. As Leon has already mentioned, those are in separate emote sets.
To solve this "issue", we would have to hard-code emote set IDs or change the way how emotes are grouped.

Is it possible to group them into a single group like those holiday emotes and lgbt+ emotes?

No, I don't think so since emotes you mentioned are in 1 emote set, but the GlitchCon ones aren't.

@zneix
Copy link
Collaborator

zneix commented Jul 4, 2021

As suggested in #2954 (comment) I could consider adding another section / tab for twitch's seasonal emotes. It sounds like a good concept, but has to be made well.

Put seasonal/event emotes in a seperate tab in the emote menu as they aren't sub emotes after all.

Another option is to collapse emotesets. I recall having a discussion about it with @leon-richardt few months ago, but I forgot how feasible would it be to do.

Option to selectively hide/collapse emote sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants