Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode Event Emotes in the Emote Menu to "Twitch" #2961

Closed
Felanbird opened this issue Jul 4, 2021 · 2 comments
Closed

Hardcode Event Emotes in the Emote Menu to "Twitch" #2961

Felanbird opened this issue Jul 4, 2021 · 2 comments

Comments

@Felanbird
Copy link
Collaborator

Felanbird commented Jul 4, 2021

Describe your issue

In #2905 we moved emoteset data loading directly to Helix, because of this, the event emotes stored on qa_tw_partner now show up in a section for that channel, instead of under twitch.

We should hardcode this to "Twitch" as discussed in the original PR.

Comments from #2905

Seems to work 👍
Only issue is the qa_TW_Partner user that twitch seems to use for some of the global emotes, which causes them to show under that user instead of under Twitch in the emote popup.
Could maybe handle this by manually moving emotes from that emote set to the Twitch set until this is changed by twitch or another fix is possible.

Screenshots

2021-06-21_22-54
Here's how it currently looks. I dislike the qa_TW_Partner

OS and Chatterino Version
all versions from 0021290 to 2af9284

@zneix

@Felanbird Felanbird added the issue-report An issue reported by a user. label Jul 4, 2021
@Felanbird Felanbird changed the title Hardcode Global Emotes in the Emote Menu to "Twitch" Hardcode Event Emotes in the Emote Menu to "Twitch" Jul 4, 2021
@zneix zneix self-assigned this Jul 5, 2021
@Felanbird
Copy link
Collaborator Author

Felanbird commented Aug 9, 2021

Minor Update: In an accidental change, but also being a more logical place for the emotes, in #3122 some of these emotes existing under qa_TW_Partner & all of the ones existing under Twitch have been moved to the Global tab.
Emotes that remain in the sub tab are resolved by ivr requests.

If we still plan to hardcode these together, we would now have to move them to the Global tab.

@Felanbird Felanbird added enhancement and removed issue-report An issue reported by a user. labels Nov 27, 2021
@zneix zneix removed their assignment Mar 22, 2022
@Felanbird
Copy link
Collaborator Author

done via #5239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants