Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer List should be renamed to Chatter List #4640

Closed
5 of 6 tasks
pajlada opened this issue May 16, 2023 · 5 comments · Fixed by #4974
Closed
5 of 6 tasks

Viewer List should be renamed to Chatter List #4640

pajlada opened this issue May 16, 2023 · 5 comments · Fixed by #4974

Comments

@pajlada
Copy link
Member

pajlada commented May 16, 2023

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

The name we use for the list is "Viewer List" but it's not really what the list contains.
Renaming it to "Chatter List" would also make it more in-line what Twitch calls it in web chat: "Users in Chat"

Most important is that the user-facing usage of the word is changed, this includes the wiki glossary.

Another separate refactor can then be made in code to rename internal references from Viewer ... to Chatter ...

Screenshots

No response

OS and Chatterino Version

N/A

@SputNikPlop
Copy link
Contributor

I am happy to take this up if no one else is working on this right now.

@pajlada
Copy link
Member Author

pajlada commented Jun 12, 2023

I am happy to take this up if no one else is working on this right now.

I don't think anyone is, I'll assign you the issue. Thank you!
Let us know here if you run into any issues or have any questions

@SputNikPlop
Copy link
Contributor

@pajlada Would you prefer I break what the user sees into one PR then move onto doing an internal refactor?

@pajlada
Copy link
Member Author

pajlada commented Jun 21, 2023

@pajlada Would you prefer I break what the user sees into one PR then move onto doing an internal refactor?

Splitting it up into two PRs like that sounds like a good idea, yeah!

@SputNikPlop
Copy link
Contributor

@pajlada I think I got it, just one thing I had to install Rosetta 2 to make it work on my Mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants