Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting path to streamlink's executable AppImage only works without filename extension #5073

Closed
4 tasks done
SchimmelGelenk opened this issue Jan 8, 2024 · 3 comments
Closed
4 tasks done

Comments

@SchimmelGelenk
Copy link

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

After an excruciating amount of time trying to get streamlink work I realized the problem as stated in the title. So setting custom streamlink path in Chatterino lead to behaviour:

First:
"/home/schim/AppImages/streamlink.AppImage" -> chatterino.streamlink: Got error code 1

Then renaming the AppImage:
"/home/schim/AppImages/streamlink" -> works as intended

Screenshots

No response

OS and Chatterino Version

Chatterino 2.4.6 (commit eb8c7f2 modified) built with Qt 6.5.3 Running on KDE Flatpak runtime, kernel: 6.6.6-76060606-generic, running from Flatpak

@SchimmelGelenk SchimmelGelenk added the issue-report An issue reported by a user. label Jan 8, 2024
@SchimmelGelenk
Copy link
Author

While this can be expected behaviour, it did not occur to me as Streamlink Twitch GUI recognizes the executable regardless of the filename extension. Maybe adding a note in above the custom path box would suffice as the user is not aware how Chatterino handles the executable

@pajlada pajlada added enhancement and removed issue-report An issue reported by a user. labels Jan 9, 2024
@pajlada
Copy link
Member

pajlada commented Jan 9, 2024

The StreamLink errors/messaging can mention what the default binary path is, and what it expects the binary's name to be 👍 This would be a good first issue for someone looking to contribute

@pajlada
Copy link
Member

pajlada commented Jan 14, 2024

I'd say this is resolved by the improved documentation in #5076

@pajlada pajlada closed this as completed Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants