From 4bceb2b8ba95ccd5def069619f82a268b49562b8 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sun, 21 May 2023 11:47:41 +0200 Subject: [PATCH 1/4] chore: introduce lintable change --- src/providers/seventv/SeventvBadges.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/providers/seventv/SeventvBadges.cpp b/src/providers/seventv/SeventvBadges.cpp index 1216d0863e2..0d7af0d5e81 100644 --- a/src/providers/seventv/SeventvBadges.cpp +++ b/src/providers/seventv/SeventvBadges.cpp @@ -42,7 +42,7 @@ void SeventvBadges::loadSeventvBadges() url.setQuery(urlQuery); NetworkRequest(url) - .onSuccess([this](const NetworkResult &result) -> Outcome { + .onSuccess([this](NetworkResult result) -> Outcome { auto root = result.parseJson(); std::unique_lock lock(this->mutex_); From a9c74662a4631eeb8ab2baeceec7719a7e466b0b Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sun, 21 May 2023 11:48:58 +0200 Subject: [PATCH 2/4] fix: configure CMake for clang-tidy separately --- .github/workflows/build.yml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 27bb7e51ea2..f11e9fcbf39 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -278,10 +278,25 @@ jobs: if: matrix.clang-tidy-review && github.event_name == 'pull_request' uses: ZedThree/clang-tidy-review@v0.13.0 with: - build_dir: build + build_dir: build-clang-tidy config_file: ".clang-tidy" split_workflow: true exclude: "tests/*,lib/*" + cmake_command: >- + cmake -S. -Bbuild-clang-tidy + -DCMAKE_BUILD_TYPE=Release + -DPAJLADA_SETTINGS_USE_BOOST_FILESYSTEM=On + -DUSE_PRECOMPILED_HEADERS=OFF + -DCMAKE_EXPORT_COMPILE_COMMANDS=On + -DCHATTERINO_LTO=Off + -DCHATTERINO_PLUGINS=On + -DBUILD_WITH_QT6=Off + apt_packages: >- + qttools5-dev, qt5-image-formats-plugins, libqt5svg5-dev, + libsecret-1-dev, + libboost-dev, libboost-system-dev, libboost-filesystem-dev, + libssl-dev, + rapidjson-dev - name: clang-tidy-review upload if: matrix.clang-tidy-review && github.event_name == 'pull_request' From 50edb17a839de311bf49ce316021345a3c47ed35 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sun, 21 May 2023 16:08:36 +0200 Subject: [PATCH 3/4] chore: add changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bd82de95909..be24b4f96ef 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - Dev: Added command to set Qt's logging filter/rules at runtime (`/c2-set-logging-rules`). (#4637) - Dev: Added the ability to see & load custom themes from the Themes directory. No stable promises are made of this feature, changes might be made that breaks custom themes without notice. (#4570) - Dev: Added test cases for emote and tab completion. (#4644) +- Dev: Fixed `clang-tidy-review` action not picking up dependencies. (#4648) ## 2.4.4 From 4d438754383196140323eae031634b317740ca34 Mon Sep 17 00:00:00 2001 From: Rasmus Karlsson Date: Sun, 21 May 2023 17:30:59 +0200 Subject: [PATCH 4/4] Revert "chore: introduce lintable change" This reverts commit 4bceb2b8ba95ccd5def069619f82a268b49562b8. --- src/providers/seventv/SeventvBadges.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/providers/seventv/SeventvBadges.cpp b/src/providers/seventv/SeventvBadges.cpp index 0d7af0d5e81..1216d0863e2 100644 --- a/src/providers/seventv/SeventvBadges.cpp +++ b/src/providers/seventv/SeventvBadges.cpp @@ -42,7 +42,7 @@ void SeventvBadges::loadSeventvBadges() url.setQuery(urlQuery); NetworkRequest(url) - .onSuccess([this](NetworkResult result) -> Outcome { + .onSuccess([this](const NetworkResult &result) -> Outcome { auto root = result.parseJson(); std::unique_lock lock(this->mutex_);